Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for Nova text editor #343

Merged
merged 1 commit into from
Dec 28, 2020
Merged

Conversation

ngurney
Copy link
Contributor

@ngurney ngurney commented Dec 28, 2020

Added support for the Nova text editor (nova.app) and updated the config comments to include it in the list of options.

Disclaimer: I am new to programming and open source, if I missed something please reject

Added support for the Nova text editor (nova.app) and updated the config comments to include it in the list of options.
@freekmurze freekmurze merged commit 77c13a2 into facade:master Dec 28, 2020
@freekmurze
Copy link
Collaborator

Thank you so much for this. 👍

Enjoy your first merged contribution. 🎉

Please do it again in the future 🙂

@ngurney
Copy link
Contributor Author

ngurney commented Dec 28, 2020

Thanks @freekmurze! Hoping you can help me understand why it isn't working? I see the updates in my codebase in the config/ignition.php file, but I don't see them in the minified JS and I am not getting a working link. I ran composer update but no luck with that.

@freekmurze
Copy link
Collaborator

I forgot to add the compiled js to the release.

Just corrected that in 2.5.5

@ngurney
Copy link
Contributor Author

ngurney commented Dec 29, 2020

@freekmurze cool, I can see that the js is updated now. I now get no content on the page though when I expect to see an error 😬 all I can see is the error title in my browser tab. Occurring on all browsers ever since I updated to 2.5.5, perhaps caused by something here?

@freekmurze
Copy link
Collaborator

I could reproduce this, and @AdrianMrn is investigating this now.

@freekmurze
Copy link
Collaborator

Seems like I accidentally merged in a breaking change in one of the js dependency. @AdrianMrn fixed it in the latest version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants