-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatically fix blade variable typos and optional variables #38
Automatically fix blade variable typos and optional variables #38
Conversation
This looks awesome. I’ll review it soon. Thanks! |
Thanks! :) |
I'm happy with this if you are, will use draft PRs in future while I'm still working on it |
Thanks for the feedback. All sorted! |
Good to merge? |
…fined-variable-solution
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some more nitpicks. After that I think it'll be ready for merge.
Awesome PR 👍
…fined-variable-solution
We don't know which object it will return, BaseSolution or MakeViewVariableOptionalSolution
This is good to merge. 👍 |
Great job on this PR! Thank you! |
This PR adds a solution for fixing undefined variables in view files.
The Solution Provider
?? ''
The Solutions
This is to ensure we never break a blade template, it also allows us to build upon the basic find and replace logic in the future.
Automated Tests
There are some automated tests around this, we can expand to include more difficult cases.