Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove encoding for newer transition criterion until finalized #1957

Closed
wants to merge 1 commit into from

Conversation

mgarrard
Copy link
Contributor

@mgarrard mgarrard commented Nov 3, 2023

Summary: i introduced some backwards compatability issues because i added transition criterion to the encoder/decoder that were still in flux. I forgot that those would be added to newly created exp and then cause backwards compatability issues. This diff removes those

Reviewed By: lena-kashtelyan

Differential Revision: D50890889

Summary: i introduced some backwards compatability issues because i added transition criterion to the encoder/decoder that were still in flux. I forgot that those would be added to newly created exp and then cause backwards compatability issues. This diff removes those

Reviewed By: lena-kashtelyan

Differential Revision: D50890889
@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Nov 3, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D50890889

@codecov-commenter
Copy link

codecov-commenter commented Nov 3, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (52c9018) 94.61% compared to head (c651172) 94.61%.

❗ Current head c651172 differs from pull request most recent head 154e264. Consider uploading reports for the commit 154e264 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1957      +/-   ##
==========================================
- Coverage   94.61%   94.61%   -0.01%     
==========================================
  Files         459      459              
  Lines       43645    43650       +5     
==========================================
+ Hits        41294    41298       +4     
- Misses       2351     2352       +1     
Files Coverage Δ
ax/modelbridge/generation_strategy.py 95.16% <100.00%> (+0.02%) ⬆️
ax/service/tests/test_ax_client.py 98.97% <100.00%> (+<0.01%) ⬆️
ax/service/tests/test_scheduler.py 99.38% <100.00%> (-0.21%) ⬇️
ax/storage/json_store/decoder.py 87.28% <100.00%> (-0.17%) ⬇️
ax/storage/json_store/tests/test_json_store.py 94.38% <100.00%> (+0.12%) ⬆️
ax/storage/sqa_store/tests/test_sqa_store.py 99.01% <100.00%> (+<0.01%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in cd564e4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity. fb-exported Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants