Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error in make_tutorials.py #2066

Closed
wants to merge 1 commit into from

Conversation

Balandat
Copy link
Contributor

@Balandat Balandat commented Dec 9, 2023

If env is None then this raises a 'NoneType' object has no attribute 'items' error. This change fixes this issue and simplifies the setup.

If `env` is `None` then this raises a `'NoneType' object has no attribute 'items'` error.
This change fixes this issue and simplifies the setup.
@Balandat Balandat requested a review from saitcakmak December 9, 2023 07:04
@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Dec 9, 2023
@facebook-github-bot
Copy link
Contributor

@Balandat has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@codecov-commenter
Copy link

codecov-commenter commented Dec 9, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (afae7f0) 94.62% compared to head (d7b4800) 94.62%.

❗ Current head d7b4800 differs from pull request most recent head e5f69ea. Consider uploading reports for the commit e5f69ea to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2066   +/-   ##
=======================================
  Coverage   94.62%   94.62%           
=======================================
  Files         460      460           
  Lines       44895    44895           
=======================================
  Hits        42484    42484           
  Misses       2411     2411           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@facebook-github-bot
Copy link
Contributor

@Balandat merged this pull request in 35ec389.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity. Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants