Make sure is_ax_equal returns a boolean #2714
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: This is an alternative to D61666276 that addresses some of the issues raised there. Instead of checking for type equality, which is too restrictive, we attempt to cast the output of the equality comparison to a boolean. If the cast or the comparison fails, we return False. This ensures that the output of `is_ax_equal` is always a boolean and can be used in `if` statements. Also documented some of the special cases used in this method, as its behavior can sometimes be unintuitive. Differential Revision: D61803910
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D61803910 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2714 +/- ##
=======================================
Coverage 95.28% 95.29%
=======================================
Files 493 493
Lines 47919 47926 +7
=======================================
+ Hits 45662 45669 +7
Misses 2257 2257 ☔ View full report in Codecov by Sentry. |
|
This pull request has been merged in af8eab3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This is an alternative to D61666276 that addresses some of the issues raised there.
Instead of checking for type equality, which is too restrictive, we attempt to cast the output of the equality comparison to a boolean. If the cast or the comparison fails, we return False. This ensures that the output of
is_ax_equalis always a boolean and can be used inifstatements.Also documented some of the special cases used in this method, as its behavior can sometimes be unintuitive.
Differential Revision: D61803910