Apply PEP 604 union type syntax codemod #2808
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2808 +/- ##
=======================================
Coverage 95.71% 95.71%
=======================================
Files 490 490
Lines 48555 48532 -23
=======================================
- Hits 46472 46451 -21
+ Misses 2083 2081 -2 ☔ View full report in Codecov by Sentry. |
|
@Balandat has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
This pull request was exported from Phabricator. Differential Revision: D63764095 |
Balandat
added a commit
to Balandat/Ax
that referenced
this pull request
Oct 2, 2024
Summary: This codemods all `Optional[X]` type definitions to use the PEP 604 syntax `X | None` instead. Pull Request resolved: facebook#2808 Reviewed By: mpolson64 Differential Revision: D63764095 Pulled By: Balandat
|
This pull request was exported from Phabricator. Differential Revision: D63764095 |
Balandat
added a commit
to Balandat/Ax
that referenced
this pull request
Oct 2, 2024
Summary: This codemods all `Optional[X]` type definitions to use the PEP 604 syntax `X | None` instead. Pull Request resolved: facebook#2808 Reviewed By: mpolson64 Differential Revision: D63764095 Pulled By: Balandat
|
This pull request was exported from Phabricator. Differential Revision: D63764095 |
Balandat
added a commit
to Balandat/Ax
that referenced
this pull request
Oct 2, 2024
Summary: This codemods all `Optional[X]` type definitions to use the PEP 604 syntax `X | None` instead. Pull Request resolved: facebook#2808 Reviewed By: mpolson64 Differential Revision: D63764095 Pulled By: Balandat
Balandat
added a commit
to Balandat/Ax
that referenced
this pull request
Oct 2, 2024
Summary: This codemods all `Optional[X]` type definitions to use the PEP 604 syntax `X | None` instead. Pull Request resolved: facebook#2808 Reviewed By: mpolson64 Differential Revision: D63764095 Pulled By: Balandat
|
This pull request was exported from Phabricator. Differential Revision: D63764095 |
Summary: This codemods all `Optional[X]` type definitions to use the PEP 604 syntax `X | None` instead. Pull Request resolved: facebook#2808 Reviewed By: mpolson64 Differential Revision: D63764095 Pulled By: Balandat
|
This pull request was exported from Phabricator. Differential Revision: D63764095 |
Balandat
added a commit
to Balandat/Ax
that referenced
this pull request
Oct 3, 2024
facebook#2808 moved to PEP604 optional type annotiation. Apparently this broke some code that worked fined wiht the previously used `Optional[DBSettings]` even if `DBSettings` was not defined. I'm not entirely sure what's going on; this is more than about just delayed type annotations. Anyway, this is a hotfix that returns that code to the previous state.
facebook-github-bot
pushed a commit
that referenced
this pull request
Oct 3, 2024
Summary: #2808 moved to PEP604 optional type annotiation. Apparently this broke some code that worked fined wiht the previously used `Optional[DBSettings]` even if `DBSettings` was not defined. I'm not entirely sure what's going on; this is more than about just delayed type annotations. Anyway, this is a hotfix that returns that code to the previous state. Pull Request resolved: #2819 Reviewed By: saitcakmak Differential Revision: D63834254 Pulled By: Balandat fbshipit-source-id: 9ca80b263816d4bae9451375d5cd212752ed23c8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This codemods all
Optional[X]type definitions to use the PEP 604 syntaxX | Noneinstead.