Extract constraint violation logic for common use #2811
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D63656156 |
danielcohenlive
pushed a commit
to danielcohenlive/Ax-1
that referenced
this pull request
Oct 2, 2024
Summary: Move `get_constraint_violated_probabilities()` to a utils file and give it its own tests. No changes were made to `get_constraint_violated_probabilities()` Reviewed By: Cesar-Cardoso Differential Revision: D63656156
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2811 +/- ##
==========================================
+ Coverage 95.71% 95.72% +0.01%
==========================================
Files 490 492 +2
Lines 48555 48581 +26
==========================================
+ Hits 46472 46503 +31
+ Misses 2083 2078 -5 ☔ View full report in Codecov by Sentry. |
Summary: Move `get_constraint_violated_probabilities()` to a utils file and give it its own tests. No changes were made to `get_constraint_violated_probabilities()` Reviewed By: Cesar-Cardoso Differential Revision: D63656156
danielcohenlive
force-pushed
the
export-D63656156
branch
from
51e438f to
3d7fa3b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D63656156 |
danielcohenlive
pushed a commit
to danielcohenlive/Ax-1
that referenced
this pull request
Oct 2, 2024
Summary: Move `get_constraint_violated_probabilities()` to a utils file and give it its own tests. No changes were made to `get_constraint_violated_probabilities()` Reviewed By: Cesar-Cardoso Differential Revision: D63656156
danielcohenlive
pushed a commit
to danielcohenlive/Ax-1
that referenced
this pull request
Oct 2, 2024
Summary: Move `get_constraint_violated_probabilities()` to a utils file and give it its own tests. No changes were made to `get_constraint_violated_probabilities()` Reviewed By: Cesar-Cardoso Differential Revision: D63656156
|
This pull request has been merged in a4ba55d. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Move
get_constraint_violated_probabilities()to a utils file and give it its own tests. No changes were made toget_constraint_violated_probabilities()Reviewed By: Cesar-Cardoso
Differential Revision: D63656156