Correct timeout logic #2825
Closed
Correct timeout logic #2825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D63920497 |
Summary: Context: D61930178 introduced incorrect timeout logic. At each iteration, the time remaining was decremented by the *total* amount of time elapsed so far. So if there were n iterations that each took 1 second, the time remaining would be decremented by n * (n + 1) / 2 seconds, rather than n seconds. This was also happening silently, whereas timing out within Scheduler would log a warning. This diff: * Fixes the timeout logic * Logs a warning Reviewed By: sdaulton, Balandat Differential Revision: D63920497
esantorella
force-pushed
the
export-D63920497
branch
from
f94465c to
8daaabd
Compare
|
This pull request was exported from Phabricator. Differential Revision: D63920497 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2825 +/- ##
=======================================
Coverage 95.71% 95.71%
=======================================
Files 492 492
Lines 48583 48591 +8
=======================================
+ Hits 46499 46507 +8
Misses 2084 2084 ☔ View full report in Codecov by Sentry. |
|
This pull request has been merged in c077378. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Context:
D61930178 introduced incorrect timeout logic. At each iteration, the time remaining was decremented by the total amount of time elapsed so far. So if there were n iterations that each took 1 second, the time remaining would be decremented by n * (n + 1) / 2 seconds, rather than n seconds. This was also happening silently, whereas timing out within Scheduler would log a warning.
This diff:
Differential Revision: D63920497