Don't discard abandoned arms on reduced state #3261
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D68514688 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3261 +/- ##
==========================================
- Coverage 96.00% 96.00% -0.01%
==========================================
Files 512 512
Lines 51695 51690 -5
==========================================
- Hits 49632 49627 -5
Misses 2063 2063 ☔ View full report in Codecov by Sentry. |
Summary: Reduced state does still have use for leaving out gen metadata, but I don't know of any use cases with such a huge amount of abandoned arms this will make a difference (considering it can never make more than a 50% difference). It also affects the contents/functionality of the experiment by making it look like arms are not abandoned and should be used on trials. And loading and saving with reduced state loses records that arms were abandoned, which creates problems in experimentation. See N6450800 Differential Revision: D68514688
danielcohenlive
force-pushed
the
export-D68514688
branch
from
648e4f6 to
aafd890
Compare
|
This pull request was exported from Phabricator. Differential Revision: D68514688 |
|
This pull request has been merged in 526ef44. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Reduced state does still have use for leaving out gen metadata, but I don't know of any use cases with such a huge amount of abandoned arms this will make a difference (considering it can never make more than a 50% difference).
It also affects the contents/functionality of the experiment by making it look like arms are not abandoned and should be used on trials. And loading and saving with reduced state loses records that arms were abandoned, which creates problems in experimentation. See N6450800
Differential Revision: D68514688