Add concept of recoverable errors respected by Scheduler #3262
+143
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D68273328 |
danielcohenlive
pushed a commit
to danielcohenlive/Ax-1
that referenced
this pull request
Jan 22, 2025
Summary: The motivation is that some metrics are flaky and we don't want to fail the trial just because we encountered one exception fetching. Especially trials with `period_of_new_data_after_trial_completion()` > 0. This alternative to implementing this on the metric is that the set of recoverable errors should be a scheduler option, and it's more a matter of scheduler use case than metric. Reviewed By: Cesar-Cardoso Differential Revision: D68273328
danielcohenlive
force-pushed
the
export-D68273328
branch
from
9a1617e to
eb0c7d7
Compare
|
This pull request was exported from Phabricator. Differential Revision: D68273328 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3262 +/- ##
==========================================
- Coverage 96.00% 96.00% -0.01%
==========================================
Files 512 512
Lines 51695 51720 +25
==========================================
+ Hits 49632 49656 +24
- Misses 2063 2064 +1 ☔ View full report in Codecov by Sentry. |
Summary: The motivation is that some metrics are flaky and we don't want to fail the trial just because we encountered one exception fetching. Especially trials with `period_of_new_data_after_trial_completion()` > 0. This alternative to implementing this on the metric is that the set of recoverable errors should be a scheduler option, and it's more a matter of scheduler use case than metric. Reviewed By: Cesar-Cardoso Differential Revision: D68273328
danielcohenlive
force-pushed
the
export-D68273328
branch
from
eb0c7d7 to
abc2381
Compare
|
This pull request was exported from Phabricator. Differential Revision: D68273328 |
|
This pull request has been merged in 4f63561. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The motivation is that some metrics are flaky and we don't want to fail the trial just because we encountered one exception fetching. Especially trials with
period_of_new_data_after_trial_completion()> 0.This alternative to implementing this on the metric is that the set of recoverable errors should be a scheduler option, and it's more a matter of scheduler use case than metric.
Reviewed By: Cesar-Cardoso
Differential Revision: D68273328