Check data length and IANA for OEM commands #267
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: - BIC will hang up if OEM command with no data is received, as following bic-util slot1 0xe0 0x60 - IPMI message retains previous data, if the retained data is same as IANA, the check will pass even data length is zero. - Fixed it by checking data length and IANA. Test plan: Build code: PASS
facebook-github-bot
added
the
CLA Signed
|
@GoldenBug has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
GoldenBug
approved these changes
Apr 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
BIC will hang if OEM command with no data is received, as following
bic-util slot1 0xe0 0x60
IPMI message have indeterminate default data, if current data length
is zero but default data is the same as IANA, the check will still pass.
Fixed it by checking data length and IANA.
Test plan: