fby3.5 : Fix ASD connection performance issue #277
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: - Decrease ASD connection cscript time from 14min to 4min - Reduce ipmb tx/rx sleep polling time from 10ms to 1ms Test Plan: - Build code: Pass - Do experiments as below: - Before : Test item Test time ASD connect cscript 14m:16.25 sec go() 5 sec halt() 19 sec pcie.topology() 6m:34 sec CPU IERR 16m:02.56 sec DIMM correctable error 47m:09.32 sec(DDR5) PCIE correctable error 30.40 sec - After reduce polling time to 1ms: Test item Test time ASD connect cscript 3m:52s go() 3 sec halt() 8 sec pcie.topology() 1m:55 sec CPU IERR 9m:42 sec DIMM correctable error 6m:20 sec PCIE correctable error 29.7 sec
facebook-github-bot
added
the
CLA Signed
|
@GoldenBug has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
KaidanWu-wiwynn
added a commit
to Wiwynn/OpenBIC
that referenced
this pull request
Jun 21, 2022
Remove PMIC support from official v2022.19.1 version Revert "fby3.5 : Fix ASD connection performance issue (facebook#277)" This reverts commit 559e44d.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Test Plan:
Before :
Test item Test time
ASD connect cscript 14m:16.25 sec
go() 5 sec
halt() 19 sec
pcie.topology() 6m:34 sec
CPU IERR 16m:02.56 sec
DIMM correctable error 47m:09.32 sec(DDR5)
PCIE correctable error 30.40 sec
After reduce polling time to 1ms:
Test item Test time
ASD connect cscript 3m:52s
go() 3 sec
halt() 8 sec
pcie.topology() 1m:55 sec
CPU IERR 9m:42 sec
DIMM correctable error 6m:20 sec
PCIE correctable error 29.7 sec