Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fby3.5: cl: Modify PMIC pre-read function #327

Closed
wants to merge 1 commit into from
Closed

fby3.5: cl: Modify PMIC pre-read function #327

wants to merge 1 commit into from

Conversation

Yi-Shum
Copy link
Collaborator

@Yi-Shum Yi-Shum commented Jun 9, 2022

Summary:

  • In function driver_init(), pre-read function for each sensor is called.
    The pre-read function of the PMIC sensor sends IPMB message to ME, but IPMB is not ready at this time.
    It causes unexpected behavior.
  • Modify PMIC initialization function and pre-read function to avoid sending IPMB message to ME before IPMI initialization.
  • Fix PMIC smbus address as described in DIMM PMIC sensors problem #323 .

Test Plan:

  • Build code: PASS
  • Sensor read: PASS
root@bmc-oob:~# sensor-util slot1 | grep PMIC
DIMMA PMIC_Pout              (0x1E) :    0.38 Watts | (ok)
DIMMC PMIC_Pout              (0x1F) :    0.52 Watts | (ok)
DIMMD PMIC_Pout              (0x36) :    0.75 Watts | (ok)
DIMME PMIC_Pout              (0x37) :    0.60 Watts | (ok)
DIMMG PMIC_Pout              (0x42) :    0.50 Watts | (ok)
DIMMH PMIC_Pout              (0x47) :    0.50 Watts | (ok)

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 9, 2022
@Yi-Shum
fby3.5: cl: Modify PMIC pre-read function
23669bf 
Summary:
- Modify PMIC pre-read function to avoid send IPMB message to ME before
IPMI initialization.

Test Plan:
- Build code: PASS
@Yi-Shum Yi-Shum force-pushed the fby3.5-Modify_PMIC_pre_read_function branch from c6583cd to 23669bf Compare June 9, 2022 09:45
@facebook-github-bot
Copy link
Contributor

@GoldenBug has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

MouchenHung-QUANTA added a commit to MouchenHung-QUANTA/OpenBIC that referenced this pull request Jun 22, 2022
@MouchenHung-QUANTA
wc: mb: Modify PMIC sensor read
7c09176 
[Feature]
- Modify PMIC code based on facebook#327

[BugFix]
- none

[Note]
- none
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Yi-Shum @facebook-github-bot