common: ltc4282: support ein reading #348
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
@GoldenBug has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
GoldenBug
suggested changes
Jun 21, 2022
common/dev/ltc4282.c
Outdated
Comment on lines
33
to
42
| if (op == SET_BIT) { | ||
| msg->data[1] = SETBIT(msg->data[1], bit); | ||
| } else if (op == CLEAR_BIT) { | ||
| msg->data[1] = CLEARBIT(msg->data[1], bit); | ||
| } else { | ||
| return -1; | ||
| } |
There was a problem hiding this comment.
Please change to a switch statement
There was a problem hiding this comment.
Hi @GoldenBug,
We've changed it to switch statement, please help review it again, thanks.
Regards,
Jerry
Summary: Support ltc4282 ein reading. Test plan: Build and test pass on fby35 1. Bind ein reading on sensor number: 0xD8 and check reading is correct root@bmc-oob:~# sensor-util slot1 | grep 0xD8 BB_MEDUSA_PWR (0xD8) : 62.67 Watts | (ok)
Jerry-wiwynn
force-pushed
the
Jerry/main/ltc4282_ein
branch
from
bd5f1e5
to
3e380d4
Compare
|
@DelphineChiu has updated the pull request. You must reimport the pull request before landing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Support ltc4282 ein reading.
Test plan:
Build and test pass on fby35
root@bmc-oob:~# sensor-util slot1 | grep 0xD8
BB_MEDUSA_PWR (0xD8) : 62.67 Watts | (ok)