fby3.5: rf: Update the GPIO configurations. #374
Conversation
|
Hi @Scron-Chang! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
Scron-Chang
force-pushed
the
dev_scron_RF_Update_GPIO_config
branch
2 times, most recently
from
a2fda1c
to
85673c1
Compare
|
Hello, Could you please complete the CLA. It's not possible to continue until that is finished. |
|
Hi @GoldenBug, |
Scron-Chang
force-pushed
the
dev_scron_RF_Update_GPIO_config
branch
3 times, most recently
from
a6819be
to
4473cff
Compare
|
I rebased this branch and updated the description of this PR. In addition, I removed the log of the BIC console because the RainbowFalls board I am using is incomplete and could cause confusion to the reviewer. If I get the complete RainbowFalls, I will check this PR with it immediately. |
|
Any updates on the CLA? |
Scron-Chang
force-pushed
the
dev_scron_RF_Update_GPIO_config
branch
from
4473cff
to
a142186
Compare
My manager has sent a mail for my CLA, but we don't receive any response from Meta. Would you kindly check the email box for that? |
|
I received the Rainbow Falls board. I updated the code based on the suggestions from @GoldenBug and tested it. Also, the description of this PR has been updated. There now are the result of the gpio list and the reaction of PM8702 when BIC reboots. |
facebook-github-bot
added
the
CLA Signed
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
- Change the configurations of default state, output type, direction:
- GPIOA2:
Set GPIOA2 as default low to not enable the recovery mode of the
CXL controller.
- GPIOA6:
Set as output and default high because BIC may need to reset JTAG
directly in a particular case.
- GPIOA7:
Set as default low to set the JTAG mode.
- GPIOB1:
Set as default low to set CXL controller boots from its own ROM in
the default situation.
- GPIOB3:
Set as input to not control the CXL controller GPIO_0.
- GPIOB6:
Set as default high to avoid resetting the I2C interface of the
CXL controller when BIC reboots.
- GPIOF0:
Set as default high and open-drain output type. This pin controls
the flash memory which uses 1.8V.
- GPIOF1:
Set as default high to match the default HW state.
- GPIOH2:
Set as Output and default low to enable the SPI buffer in the
default mode.
- Enable the latch feature for the following GPIOs to avoid making
unexpected consequences:
- GPIOA0/1:
These two pins trigger the cold and warm reset signal on the CXL
controller, respectively.
- GPIOC0~D1:
These pin control the power deliver.
- GPIOE1:
This pin is used to inform the mainboard that Rainbow Falls is
ready.
- GPIOF2:
This pin controls the buffer handling the voltage shift.
Tested:
- Rainbow Falls platfrom build: Pass.
- BIC warm reboot doesn't affect the PM8702. I have verified this from
the PM8702 console.
- Console logs from the RF BIC:
```
[set_MB_DC_status] gpio number(32) status(1)
[control_power_on_sequence] power on success
[set_DC_status] gpio number(33) status(1)
uart:~$ platform gpio list_all
[0 ] ASIC_DEV_RST_N : OD | output(I) | 1(1)
[1 ] ASIC_PERST0_N : OD | output(I) | 1(1)
[2 ] ASIC_PERST1_N : OD | output(O) | 0(0)
[6 ] JTAG2_BIC_ASIC_NTRST2 : PP | output(O) | 1(1)
[7 ] ASIC_TAP_SEL : OD | output(O) | 0(0)
[9 ] ASIC_CPU_BOOT_1 : OD | output(O) | 0(0)
[11 ] ASIC_GPIO_R_0 : OD | input (I) | 1(1)
[14 ] I2CS_SRSTB_GPIO : OD | output(I) | 1(1)
[35 ] SPI_MASTER_SEL : PP | output(O) | 0(0)
[40 ] SPI_RST_FLASH_N : OD | output(I) | 0(0)
[41 ] SMBUS_ALERT_R_N : OD | output(I) | 1(1)
[58 ] SPI_BIC_SHIFT_EN : OD | output(O) | 0(0)
```
Signed-off-by: Scron Chang <Scron.Chang@quantatw.com>
Scron-Chang
force-pushed
the
dev_scron_RF_Update_GPIO_config
branch
from
a142186
to
e3f85a5
Compare
|
Hi @GoldenBug , |
|
@garnermic has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Change the configurations of default state, output type, direction:
GPIOA2:
Set GPIOA2 as default low to not enable the recovery mode of the
CXL controller.
GPIOA6:
Set as output and default high because BIC may need to reset JTAG
directly in a particular case.
GPIOA7:
Set as default low to set the JTAG mode.
GPIOB1:
Set as default low to set CXL controller boots from its own ROM in
the default situation.
GPIOB3:
Set as input to not control the CXL controller GPIO_0.
GPIOB6:
Set as default high to avoid resetting the I2C interface of the
CXL controller when BIC reboots.
GPIOF0:
Set as default high and open-drain output type. This pin controls
the flash memory which uses 1.8V.
GPIOF1:
Set as default high to match the default HW state.
GPIOH2:
Set as Output and default low to enable the SPI buffer in the
default mode.
Enable the latch feature for the following GPIOs to avoid making
unexpected consequences:
GPIOA0/1:
These two pins trigger the cold and warm reset signal on the CXL
controller, respectively.
GPIOC0~D1:
These pin control the power deliver.
GPIOE1:
This pin is used to inform the mainboard that Rainbow Falls is
ready.
GPIOF2:
This pin controls the buffer handling the voltage shift.
Tested:
the PM8702 console.
Signed-off-by: Scron Chang Scron.Chang@quantatw.com