fby3.5: hd: Initialize HalfDome BIC #377
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Summary:
- Initialize HalfDome BIC.
- Create project config, dts files, file header, and CMake file.
- Add project code in meta-facebook/yv35-hd/.
Test plan:
- Build code: PASS
- Can access BIC console: PASS
LOG:
1. Build code pass.
```
$ west build -b ast1030_evb -p auto ./meta-facebook/yv35-hd/
...
[254/261] Linking C executable zephyr/zephyr_prebuilt.elf
[261/261] Linking C executable zephyr/Y35BHD.elf
Memory region Used Size Region Size %age Used
SRAM_NC: 152 KB 320 KB 47.50%
FLASH: 0 GB 0 GB
SRAM: 385440 B 448 KB 84.02%
IDT_LIST: 0 GB 2 KB 0.00%
```
2. BIC console:
```
[00:00:00.002,000] <wrn> usb_dc_aspe*** Booting Zephyr OS build v00.01.05-5-g6163ab05ded5 ***
Hello, welcome to yv35 halfdome ffff.ff.ff
```
Yi-Shum
force-pushed
the
fby3.5-Initialize_HalfDome_BIC
branch
from
5d18886
to
ff66dd9
Compare
|
@GoldenBug has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
GoldenBug
suggested changes
Jul 7, 2022
meta-facebook/yv35-hd/prj.conf
Outdated
| CONFIG_THREAD_NAME=y | ||
| CONFIG_THREAD_STACK_INFO=y | ||
| CONFIG_THREAD_MONITOR=y | ||
| CONFIG_IRQ_OFFLOAD=y |
There was a problem hiding this comment.
This is only needed for testing so it can be removed.
There was a problem hiding this comment.
OK, I will remove this config.
meta-facebook/yv35-hd/prj.conf
Outdated
| CONFIG_CMSIS_V2_MEM_SLAB_MAX_DYNAMIC_SIZE=128 | ||
| CONFIG_CMSIS_V2_THREAD_MAX_COUNT=23 | ||
| CONFIG_CMSIS_V2_THREAD_DYNAMIC_MAX_COUNT=10 | ||
| CONFIG_TIMEOUT_64BIT=n |
There was a problem hiding this comment.
This is force y by other options so it can be removed from this config as well.
There was a problem hiding this comment.
OK, I will remove this config.
| target_sources(app PRIVATE ${common_sources}) | ||
| target_include_directories(app PRIVATE ${ZEPHYR_BASE}/include/portability) | ||
| target_include_directories(app PRIVATE ${common_path} ${common_path}/service/ipmi/include ${common_path}/service/host ${common_path}/service/sensor ${common_path}/service/usb ${common_path}/service/ipmb ${common_path}/service/mctp ${common_path}/service/pldm ${common_path}/hal ${common_path}/dev/include ${common_path}/lib ${common_path}/shell) | ||
| target_include_directories(app PRIVATE src/ipmi/include src/lib src/platform) |
There was a problem hiding this comment.
Add
# Fail build if there are any warnings
target_compile_options(app PRIVATE -Werror)
| #define SELF_I2C_ADDRESS 0x20 | ||
| #define MAX_IPMB_IDX 2 | ||
|
|
||
| extern IPMB_config pal_IPMB_config_table[]; |
There was a problem hiding this comment.
IPMB will be supported in PR #378, so I'll keep this.
|
@Yi-Shum has updated the pull request. You must reimport the pull request before landing. |
|
Hi @GoldenBug , |
|
@GoldenBug has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Jul 8, 2022
Summary: - Support IPMB handler. Dependency: #377 Pull Request resolved: #378 Test Plan: - Build code: Pass - Check IPMB is workable: Pass LOG: ``` root@bmc-oob:~# bic-util slot1 0x18 0x1 00 80 FF FF 02 BF 15 A0 00 00 00 00 00 00 00 ``` Reviewed By: garnermic Differential Revision: D37679073 Pulled By: GoldenBug fbshipit-source-id: 1733c51fca36362abe08074b60f91f9d915b6645
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Test plan:
LOG: