fby3: dl: Add oem get fw version for server board #418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: - as the title.
facebook-github-bot
added
the
CLA Signed
|
@GoldenBug has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
GoldenBug
suggested changes
Jul 18, 2022
Comment on lines
+90
to
+176
| i2c_msg.tx_len = 1; | ||
| i2c_msg.rx_len = 7; | ||
| i2c_msg.bus = I2C_BUS8; | ||
| i2c_msg.data[0] = PMBUS_IC_DEVICE_ID; | ||
|
|
||
| if (i2c_master_read(&i2c_msg, retry)) { | ||
| msg->completion_code = CC_UNSPECIFIED_ERROR; | ||
| return; | ||
| } | ||
|
|
||
| if (memcmp(i2c_msg.data, ISL69254_DEVICE_ID, sizeof(ISL69254_DEVICE_ID)) == 0) { | ||
| /* Renesas isl69254 */ | ||
| i2c_msg.tx_len = 3; | ||
| i2c_msg.data[0] = 0xC7; //command code | ||
| i2c_msg.data[1] = 0x3F; //register | ||
| i2c_msg.data[2] = 0x00; //dummy data | ||
|
|
||
| if (i2c_master_write(&i2c_msg, retry)) { | ||
| msg->completion_code = CC_UNSPECIFIED_ERROR; | ||
| return; | ||
| } | ||
|
|
||
| i2c_msg.tx_len = 1; | ||
| i2c_msg.rx_len = 4; | ||
| i2c_msg.data[0] = 0xC5; //command code | ||
|
|
||
| if (i2c_master_read(&i2c_msg, retry)) { | ||
| msg->completion_code = CC_UNSPECIFIED_ERROR; | ||
| return; | ||
| } | ||
|
|
||
| msg->data[0] = i2c_msg.data[3]; | ||
| msg->data[1] = i2c_msg.data[2]; | ||
| msg->data[2] = i2c_msg.data[1]; | ||
| msg->data[3] = i2c_msg.data[0]; | ||
| msg->data_len = 4; | ||
| msg->completion_code = CC_SUCCESS; | ||
|
|
||
| } else if (memcmp(i2c_msg.data, XDPE12284C_DEVICE_ID, | ||
| sizeof(XDPE12284C_DEVICE_ID)) == 0) { | ||
| /* Infineon xdpe12284c */ | ||
| i2c_msg.tx_len = 2; | ||
| i2c_msg.data[0] = 0x00; | ||
| i2c_msg.data[1] = 0x62; //set page to 0x62 | ||
|
|
||
| if (i2c_master_write(&i2c_msg, retry)) { | ||
| msg->completion_code = CC_UNSPECIFIED_ERROR; | ||
| return; | ||
| } | ||
|
|
||
| //Read lower word for the 32bit checksum value | ||
| i2c_msg.tx_len = 1; | ||
| i2c_msg.rx_len = 2; | ||
| i2c_msg.data[0] = 0x43; | ||
| if (i2c_master_read(&i2c_msg, retry)) { | ||
| msg->completion_code = CC_UNSPECIFIED_ERROR; | ||
| return; | ||
| } | ||
|
|
||
| msg->data[0] = i2c_msg.data[1]; | ||
| msg->data[1] = i2c_msg.data[0]; | ||
|
|
||
| i2c_msg.tx_len = 2; | ||
| i2c_msg.data[0] = 0x00; | ||
| i2c_msg.data[1] = 0x62; //set page to 0x62 | ||
|
|
||
| if (i2c_master_write(&i2c_msg, retry)) { | ||
| msg->completion_code = CC_UNSPECIFIED_ERROR; | ||
| return; | ||
| } | ||
|
|
||
| //Read higher word for the 32bit checksum value | ||
| i2c_msg.tx_len = 1; | ||
| i2c_msg.rx_len = 2; | ||
| i2c_msg.data[0] = 0x42; | ||
| if (i2c_master_read(&i2c_msg, retry)) { | ||
| msg->completion_code = CC_UNSPECIFIED_ERROR; | ||
| return; | ||
| } | ||
|
|
||
| msg->data[2] = i2c_msg.data[1]; | ||
| msg->data[3] = i2c_msg.data[0]; | ||
| msg->data_len = 4; | ||
| msg->completion_code = CC_SUCCESS; | ||
| } else { | ||
| msg->completion_code = CC_UNSPECIFIED_ERROR; | ||
| } |
There was a problem hiding this comment.
Can we break this out into a separate function?
Comment on lines
+77
to
+88
| if ((component == DL_COMPNT_PVCCIN) || (component == DL_COMPNT_PVCCSA)) { | ||
| i2c_msg.target_addr = VCCIN_VCCSA_ADDR; | ||
| } | ||
| if ((component == DL_COMPNT_PVCCIO) || (component == DL_COMPNT_P3V3_STBY)) { | ||
| i2c_msg.target_addr = VCCIO_P3V3_STBY_ADDR; | ||
| } | ||
| if (component == DL_COMPNT_PVDDR_ABC) { | ||
| i2c_msg.target_addr = VDDQ_ABC_ADDR; | ||
| } | ||
| if (component == DL_COMPNT_PVDDR_DEF) { | ||
| i2c_msg.target_addr = VDDQ_DEF_ADDR; | ||
| } |
There was a problem hiding this comment.
Once the code below is a separate function we can pass in the target address as a parameter, and refactor these into the case statements above.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: