Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fby3: dl: Add vr hot gpio interrupt #459

Conversation

DelphineChiu
Copy link

@DelphineChiu DelphineChiu commented Aug 4, 2022

Summary:

  • Add sel when vr hot gpio interrupt.

Dependency: #458

Test plan:
build pass on fby3 dl

@DelphineChiu
Copy link
Author

Dependency: #458

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 4, 2022
@facebook-github-bot
Copy link
Contributor

@garnermic has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

1 similar comment
@facebook-github-bot
Copy link
Contributor

@garnermic has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@GoldenBug has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@GoldenBug
Copy link
Contributor

Hello, This has some conflicts with a change to how get/set ipmi commands are handled on another platform + common code.

Can you please fix conflicts + refactor what is necessary.

Summary:
- Add sel when vr hot gpio interrupt.

Test plan:
build pass on fby3 dl
@MarshallZhan-wiwynn MarshallZhan-wiwynn force-pushed the Marshall/fby3-dl/add_vr_hot_gpio_interrupt branch from 711bddc to 765e1a3 Compare August 15, 2022 07:07
@facebook-github-bot
Copy link
Contributor

@DelphineChiu has updated the pull request. You must reimport the pull request before landing.

@facebook-github-bot
Copy link
Contributor

@GoldenBug has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants