fby3.5: bb: Fix build code fail issue and correct LTC4282 sensor reading #475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
LoraLin1
force-pushed
the
fby3.5-bb-Fix_build_code_fail_issue
branch
2 times, most recently
from
b360e39
to
a8684fd
Compare
|
@GoldenBug has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
Is line 87 in meta-facebook/yv35-bb/src/platform/plat_hook.c supposed to be If so we probably just want to fix it in this PR. |
Summary: - Correct BB BIC LTC4282 sensor reading. - Modify LTC4282 sensor initial flag from true to false, making LTC4282 sensor to get adjust parameter of sensor reading from register. Test Plan: - Build code: Pass - LTC4282 sensor reading is correct: Pass Log: - Before modifying LTC4282 sensor initial flag from true to false LTC4282 sensor doesn't do initial function (Doesn't get adjust parameter of sensor reading from register) [BMC console] root@bmc-oob:~# sensor-util slot1 --thre | grep BB_MEDUSA BB_MEDUSA_VIN (0xDB) : 4.13 Volts | (lnr) | UCR: 13.88 | UNC: 13.75 | UNR: 14.00 | LCR: 11.12 | LNC: 11.25 | LNR: 9.25 BB_MEDUSA_VOUT (0xD7) : 4.13 Volts | (lnr) | UCR: 13.88 | UNC: 13.75 | UNR: 14.00 | LCR: 11.12 | LNC: 11.25 | LNR: 9.25 BB_MEDUSA_CUR (0xDF) : 17.77 Amps | (ok) | UCR: 144.00 | UNC: NA | UNR: NA | LCR: NA | LNC: NA | LNR: NA BB_MEDUSA_PWR (0xD8) : 73.33 Watts | (ok) | UCR: 1800.00 | UNC: NA | UNR: NA | LCR: NA | LNC: NA | LNR: NA - After modifying LTC4282 sensor initial flag from true to false [BMC console] root@bmc-oob:~# sensor-util slot1 --thre | grep BB_MEDUSA BB_MEDUSA_VIN (0xDB) : 12.39 Volts | (ok) | UCR: 13.88 | UNC: 13.75 | UNR: 14.00 | LCR: 11.12 | LNC: 11.25 | LNR: 9.25 BB_MEDUSA_VOUT (0xD7) : 12.39 Volts | (ok) | UCR: 13.88 | UNC: 13.75 | UNR: 14.00 | LCR: 11.12 | LNC: 11.25 | LNR: 9.25 BB_MEDUSA_CUR (0xDF) : 17.58 Amps | (ok) | UCR: 144.00 | UNC: NA | UNR: NA | LCR: NA | LNC: NA | LNR: NA BB_MEDUSA_PWR (0xD8) : 217.65 Watts | (ok) | UCR: 1800.00 | UNC: NA | UNR: NA | LCR: NA | LNC: NA | LNR: NA
LoraLin1
force-pushed
the
fby3.5-bb-Fix_build_code_fail_issue
branch
from
a8684fd
to
23e5976
Compare
|
@DelphineChiu has updated the pull request. You must reimport the pull request before landing. |
|
Hi @GoldenBug , |
|
@GoldenBug has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
GoldenBug
approved these changes
Aug 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Test Plan:
Log:
LTC4282 sensor doesn't do initial function (Doesn't get adjust parameter of sensor reading from register)
[BMC console]
root@bmc-oob:~# sensor-util slot1 --thre | grep BB_MEDUSA
BB_MEDUSA_VIN (0xDB) : 4.13 Volts | (lnr) | UCR: 13.88 | UNC: 13.75 | UNR: 14.00 | LCR: 11.12 | LNC: 11.25 | LNR: 9.25
BB_MEDUSA_VOUT (0xD7) : 4.13 Volts | (lnr) | UCR: 13.88 | UNC: 13.75 | UNR: 14.00 | LCR: 11.12 | LNC: 11.25 | LNR: 9.25
BB_MEDUSA_CUR (0xDF) : 17.77 Amps | (ok) | UCR: 144.00 | UNC: NA | UNR: NA | LCR: NA | LNC: NA | LNR: NA
BB_MEDUSA_PWR (0xD8) : 73.33 Watts | (ok) | UCR: 1800.00 | UNC: NA | UNR: NA | LCR: NA | LNC: NA | LNR: NA
[BMC console]
root@bmc-oob:~# sensor-util slot1 --thre | grep BB_MEDUSA
BB_MEDUSA_VIN (0xDB) : 12.39 Volts | (ok) | UCR: 13.88 | UNC: 13.75 | UNR: 14.00 | LCR: 11.12 | LNC: 11.25 | LNR: 9.25
BB_MEDUSA_VOUT (0xD7) : 12.39 Volts | (ok) | UCR: 13.88 | UNC: 13.75 | UNR: 14.00 | LCR: 11.12 | LNC: 11.25 | LNR: 9.25
BB_MEDUSA_CUR (0xDF) : 17.58 Amps | (ok) | UCR: 144.00 | UNC: NA | UNR: NA | LCR: NA | LNC: NA | LNR: NA
BB_MEDUSA_PWR (0xD8) : 217.65 Watts | (ok) | UCR: 1800.00 | UNC: NA | UNR: NA | LCR: NA | LNC: NA | LNR: NA