-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fby3:dl:adjust negative VR reading #506
Closed
DelphineChiu
wants to merge
1
commit into
facebook:main
from
Wiwynn:Marshall/fby3-dl/adjust_negative_value_to_zero
Closed
fby3:dl:adjust negative VR reading #506
DelphineChiu
wants to merge
1
commit into
facebook:main
from
Wiwynn:Marshall/fby3-dl/adjust_negative_value_to_zero
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary -Description: - As Infineon VR reporting current -1(A), BMC will show NA, but expecting current reading 0(A) while VR reporting -2~0(A). - As system in idle status, rarely reading VR power NA. Expecting power reading 0(W) while VR reporting -4~0(W). - Added power reading filter for Renesas VR and return power reading 0(W) as VR reporting power between -4~0(W). - Set the accessible of P3V3_STBY_VR to stby_access, because P3V3 STBY is ready after cpld turn on STBY power. Test plan: - Build code : pass. - sensor util : root@bmc-oob:~# sensor-util slot2 slot2: MB Inlet Temp (0x1) : 28.00 C | (ok) MB Outlet Temp (0x2) : 36.00 C | (ok) FRONT IO Temp (0x3) : 23.20 C | (ok) PCH Temp (0x4) : 39.00 C | (ok) SOC CPU Temp (0x5) : 37.00 C | (ok) SOC Therm Margin (0xD) : -39.00 C | (ok) SOC CPU TjMax (0x25) : 76.00 C | (ok) CPU Package Pwr (0x1E) : 13.00 Watts | (ok) SOC DIMMA Temp (0x6) : 33.00 C | (ok) SOC DIMMB Temp (0x7) : 0.00 C | (ok) SOC DIMMC Temp (0x9) : 32.00 C | (ok) SOC DIMMD Temp (0xA) : 34.00 C | (ok) SOC DIMME Temp (0xB) : 0.00 C | (ok) SOC DIMMF Temp (0xC) : 33.00 C | (ok) SSD0 Temp (0xE) : 26.00 C | (ok) HSC Temp (0xF) : 33.00 C | (ok) VCCIN VR Temp (0x10) : 39.00 C | (ok) VCCSA VR Temp (0x11) : 38.00 C | (ok) VCCIO VR Temp (0x12) : 40.00 C | (ok) 3V3_STBY VR Temp (0x13) : 38.00 C | (ok) VDDQ_ABC VR Temp (0x14) : 37.00 C | (ok) VDDQ_DEF VR Temp (0x15) : 38.00 C | (ok) P12V_STBY Vol (0x20) : 12.03 Volts | (ok) P3V_BAT Vol (0x21) : 3.12 Volts | (ok) P3V3_STBY Vol (0x22) : 3.32 Volts | (ok) P1V05_PCH Vol (0x23) : 1.06 Volts | (ok) PVNN_PCH Vol (0x24) : 1.01 Volts | (ok) HSC Input Vol (0x26) : 11.94 Volts | (ok) VCCIN VR Vol (0x27) : 1.69 Volts | (ok) VCCSA VR Vol (0x28) : 0.82 Volts | (ok) VCCIO VR Vol (0x29) : 1.01 Volts | (ok) P3V3_STBY VR Vol (0x2A) : 3.28 Volts | (ok) VDDQ_ABC VR Vol (0x2C) : 1.23 Volts | (ok) VDDQ_DEF VR Vol (0x2D) : 1.23 Volts | (ok) HSC Output Cur (0x30) : 1.80 Amps | (ok) VCCIN VR Cur (0x31) : 3.00 Amps | (ok) VCCSA VR Cur (0x32) : 2.10 Amps | (ok) VCCIO VR Cur (0x33) : 3.80 Amps | (ok) P3V3_STBY VR Cur (0x34) : 0.60 Amps | (ok) VDDQ_ABC VR Cur (0x35) : 1.25 Amps | (ok) VDDQ_DEF VR Cur (0x36) : 1.50 Amps | (ok) HSC Input Pwr (0x2E) : 22.00 Watts | (ok) HSC Input AvgPwr (0x39) : 22.00 Watts | (ok) VCCIN VR Pout (0x3A) : 6.00 Watts | (ok) VCCSA VR Pout (0x3C) : 2.00 Watts | (ok) VCCIO VR Pout (0x3D) : 3.00 Watts | (ok) P3V3_STBY VRPout (0x3E) : 1.00 Watts | (ok) VDDQ_ABC VRPout (0x3F) : 2.97 Watts | (ok) VDDQ_DEF VRPout (0x42) : 0.99 Watts | (ok)
facebook-github-bot
added
the
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
label
Aug 23, 2022
@GoldenBug has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
GoldenBug
approved these changes
Aug 23, 2022
IreneLin988
pushed a commit
to IreneLin988/OpenBIC
that referenced
this pull request
Aug 29, 2022
Summary: Summary -Description: - As Infineon VR reporting current -1(A), BMC will show NA, but expecting current reading 0(A) while VR reporting -2~0(A). - As system in idle status, rarely reading VR power NA. Expecting power reading 0(W) while VR reporting -4~0(W). - Added power reading filter for Renesas VR and return power reading 0(W) as VR reporting power between -4~0(W). - Set the accessible of P3V3_STBY_VR to stby_access, because P3V3 STBY is ready after cpld turn on STBY power. Pull Request resolved: facebook#506 Test Plan: - Build code : pass. - sensor util : root@bmc-oob:~# sensor-util slot2 slot2: MB Inlet Temp (0x1) : 28.00 C | (ok) MB Outlet Temp (0x2) : 36.00 C | (ok) FRONT IO Temp (0x3) : 23.20 C | (ok) PCH Temp (0x4) : 39.00 C | (ok) SOC CPU Temp (0x5) : 37.00 C | (ok) SOC Therm Margin (0xD) : -39.00 C | (ok) SOC CPU TjMax (0x25) : 76.00 C | (ok) CPU Package Pwr (0x1E) : 13.00 Watts | (ok) SOC DIMMA Temp (0x6) : 33.00 C | (ok) SOC DIMMB Temp (0x7) : 0.00 C | (ok) SOC DIMMC Temp (0x9) : 32.00 C | (ok) SOC DIMMD Temp (0xA) : 34.00 C | (ok) SOC DIMME Temp (0xB) : 0.00 C | (ok) SOC DIMMF Temp (0xC) : 33.00 C | (ok) SSD0 Temp (0xE) : 26.00 C | (ok) HSC Temp (0xF) : 33.00 C | (ok) VCCIN VR Temp (0x10) : 39.00 C | (ok) VCCSA VR Temp (0x11) : 38.00 C | (ok) VCCIO VR Temp (0x12) : 40.00 C | (ok) 3V3_STBY VR Temp (0x13) : 38.00 C | (ok) VDDQ_ABC VR Temp (0x14) : 37.00 C | (ok) VDDQ_DEF VR Temp (0x15) : 38.00 C | (ok) P12V_STBY Vol (0x20) : 12.03 Volts | (ok) P3V_BAT Vol (0x21) : 3.12 Volts | (ok) P3V3_STBY Vol (0x22) : 3.32 Volts | (ok) P1V05_PCH Vol (0x23) : 1.06 Volts | (ok) PVNN_PCH Vol (0x24) : 1.01 Volts | (ok) HSC Input Vol (0x26) : 11.94 Volts | (ok) VCCIN VR Vol (0x27) : 1.69 Volts | (ok) VCCSA VR Vol (0x28) : 0.82 Volts | (ok) VCCIO VR Vol (0x29) : 1.01 Volts | (ok) P3V3_STBY VR Vol (0x2A) : 3.28 Volts | (ok) VDDQ_ABC VR Vol (0x2C) : 1.23 Volts | (ok) VDDQ_DEF VR Vol (0x2D) : 1.23 Volts | (ok) HSC Output Cur (0x30) : 1.80 Amps | (ok) VCCIN VR Cur (0x31) : 3.00 Amps | (ok) VCCSA VR Cur (0x32) : 2.10 Amps | (ok) VCCIO VR Cur (0x33) : 3.80 Amps | (ok) P3V3_STBY VR Cur (0x34) : 0.60 Amps | (ok) VDDQ_ABC VR Cur (0x35) : 1.25 Amps | (ok) VDDQ_DEF VR Cur (0x36) : 1.50 Amps | (ok) HSC Input Pwr (0x2E) : 22.00 Watts | (ok) HSC Input AvgPwr (0x39) : 22.00 Watts | (ok) VCCIN VR Pout (0x3A) : 6.00 Watts | (ok) VCCSA VR Pout (0x3C) : 2.00 Watts | (ok) VCCIO VR Pout (0x3D) : 3.00 Watts | (ok) P3V3_STBY VRPout (0x3E) : 1.00 Watts | (ok) VDDQ_ABC VRPout (0x3F) : 2.97 Watts | (ok) VDDQ_DEF VRPout (0x42) : 0.99 Watts | (ok) Reviewed By: williamspatrick Differential Revision: D38936445 Pulled By: GoldenBug fbshipit-source-id: 741a9bcb9ab3a27b73df4d3ead46b32365f1d697
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
-Description:
Test plan:
root@bmc-oob:~# sensor-util slot2
slot2:
MB Inlet Temp (0x1) : 28.00 C | (ok)
MB Outlet Temp (0x2) : 36.00 C | (ok)
FRONT IO Temp (0x3) : 23.20 C | (ok)
PCH Temp (0x4) : 39.00 C | (ok)
SOC CPU Temp (0x5) : 37.00 C | (ok)
SOC Therm Margin (0xD) : -39.00 C | (ok)
SOC CPU TjMax (0x25) : 76.00 C | (ok)
CPU Package Pwr (0x1E) : 13.00 Watts | (ok)
SOC DIMMA Temp (0x6) : 33.00 C | (ok)
SOC DIMMB Temp (0x7) : 0.00 C | (ok)
SOC DIMMC Temp (0x9) : 32.00 C | (ok)
SOC DIMMD Temp (0xA) : 34.00 C | (ok)
SOC DIMME Temp (0xB) : 0.00 C | (ok)
SOC DIMMF Temp (0xC) : 33.00 C | (ok)
SSD0 Temp (0xE) : 26.00 C | (ok)
HSC Temp (0xF) : 33.00 C | (ok)
VCCIN VR Temp (0x10) : 39.00 C | (ok)
VCCSA VR Temp (0x11) : 38.00 C | (ok)
VCCIO VR Temp (0x12) : 40.00 C | (ok)
3V3_STBY VR Temp (0x13) : 38.00 C | (ok)
VDDQ_ABC VR Temp (0x14) : 37.00 C | (ok)
VDDQ_DEF VR Temp (0x15) : 38.00 C | (ok)
P12V_STBY Vol (0x20) : 12.03 Volts | (ok)
P3V_BAT Vol (0x21) : 3.12 Volts | (ok)
P3V3_STBY Vol (0x22) : 3.32 Volts | (ok)
P1V05_PCH Vol (0x23) : 1.06 Volts | (ok)
PVNN_PCH Vol (0x24) : 1.01 Volts | (ok)
HSC Input Vol (0x26) : 11.94 Volts | (ok)
VCCIN VR Vol (0x27) : 1.69 Volts | (ok)
VCCSA VR Vol (0x28) : 0.82 Volts | (ok)
VCCIO VR Vol (0x29) : 1.01 Volts | (ok)
P3V3_STBY VR Vol (0x2A) : 3.28 Volts | (ok)
VDDQ_ABC VR Vol (0x2C) : 1.23 Volts | (ok)
VDDQ_DEF VR Vol (0x2D) : 1.23 Volts | (ok)
HSC Output Cur (0x30) : 1.80 Amps | (ok)
VCCIN VR Cur (0x31) : 3.00 Amps | (ok)
VCCSA VR Cur (0x32) : 2.10 Amps | (ok)
VCCIO VR Cur (0x33) : 3.80 Amps | (ok)
P3V3_STBY VR Cur (0x34) : 0.60 Amps | (ok)
VDDQ_ABC VR Cur (0x35) : 1.25 Amps | (ok)
VDDQ_DEF VR Cur (0x36) : 1.50 Amps | (ok)
HSC Input Pwr (0x2E) : 22.00 Watts | (ok)
HSC Input AvgPwr (0x39) : 22.00 Watts | (ok)
VCCIN VR Pout (0x3A) : 6.00 Watts | (ok)
VCCSA VR Pout (0x3C) : 2.00 Watts | (ok)
VCCIO VR Pout (0x3D) : 3.00 Watts | (ok)
P3V3_STBY VRPout (0x3E) : 1.00 Watts | (ok)
VDDQ_ABC VRPout (0x3F) : 2.97 Watts | (ok)
VDDQ_DEF VRPout (0x42) : 0.99 Watts | (ok)