[HMA] Docker Release GHCR action #1585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juanmrad
force-pushed
the
hma-workflow-release-docker
branch
from
3e265a9 to
c9ad478
Compare
Dcallies
reviewed
May 8, 2024
| @@ -0,0 +1 @@ | |||
| 1.0.0 | |||
There was a problem hiding this comment.
Was debating whether we should use a < 1.0.0 version, do you have an opinion?
There was a problem hiding this comment.
I was close to do 0.0.1 lol, but also figured you may have a more strong opinion. Considering there seems to be users already with it in prod I think it is on a good state for it to be considered the first release tho.
Dcallies
approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds the version.txt file to HMA as well as the github workflow code to release the docker image into the github container registry.
Test Plan
Released image will be available
ghcr.io/facebook/ThreatExchange/hma:___version___Was only able to test up to build. 🤞🏻 push works once merged.