[py-tx] Move ISignalTypeConfigStore to python-threatexchange/storage/interfaces.py #1701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[py-tx] updated for CLI pass [py-tx] updated import path
Mackay-Fisher
changed the title
Dcallies
reviewed
Dec 2, 2024
Dcallies
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR copies the ISignalTypeConfigStore interface from HMA's storage/interface.py to python-threatexchange/threatexchange/storage/interfaces.py. This is for the first part of issue #1689, I am not sure if I was supposed to preemptively change anything within the files or directly move them up first.
I played it safe and made no functional changes in this PR, please let me know if I was supposed to implement the dbm change and I will get the pr back up as quick as possible.
Tests not applicable.