-
Notifications
You must be signed in to change notification settings - Fork 36
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Summary: With the impending implementation of `ValidationInfo`, we can kill thousands of genrules in the codebase and migrate to them `attrs_validators` which replaces all the nodes in the graph. Currently, this taps into `validation_deps` and puts the artifacts as hidden inputs so that they run. When `ValidationInfo` is released I'll update the prelude so that it puts these artifacts into `ValidationInfo` and removes the hack. ## Facebook Context: https://fb.workplace.com/groups/buck2apple/posts/801963818389446/ Original RFC: https://docs.google.com/document/d/1UccDHLPTnUedB7obVsXEpOgWYs02gpUQnR4QDeBqEHc/edit#heading=h.t4rzlrg1blvd Reviewed By: johnhaitas, rmaz Differential Revision: D59920882 fbshipit-source-id: d93395282fe8444d3bc6b965277d03ee30ea7a65
- Loading branch information
1 parent
8e07151
commit 8aa9b6b
Showing
5 changed files
with
93 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,84 @@ | ||
| # Copyright (c) Meta Platforms, Inc. and affiliates. | ||
| # | ||
| # This source code is licensed under both the MIT license found in the | ||
| # LICENSE-MIT file in the root directory of this source tree and the Apache | ||
| # License, Version 2.0 found in the LICENSE-APACHE file in the root directory | ||
| # of this source tree. | ||
|
|
||
| _RUNNABLE_EXEC_DEP = attrs.exec_dep(providers = [RunInfo]) | ||
|
|
||
| ATTRS_VALIDATORS_NAME = "attrs_validators" | ||
| ATTRS_VALIDATORS_TYPE = attrs.dict( | ||
| attrs.string(), | ||
| attrs.tuple( | ||
| # The list of attrs you want. | ||
| # If the attr key isn't available, it'll fail. | ||
| attrs.list(attrs.string()), | ||
| attrs.one_of( | ||
| # The validation script which is going to run. | ||
| # It will be passed two positional args: | ||
| # - a path to a JSON with the serialized args. | ||
| # - a path to a file to write the output. | ||
| _RUNNABLE_EXEC_DEP, | ||
| attrs.tuple( | ||
| _RUNNABLE_EXEC_DEP, | ||
| # Additional args to pass to your script. | ||
| attrs.list(attrs.arg()), | ||
| ), | ||
| ), | ||
| ), | ||
| default = {}, | ||
| ) | ||
|
|
||
| def get_attrs_validators_outputs(ctx: AnalysisContext) -> list[Artifact]: | ||
| if not hasattr(ctx.attrs, ATTRS_VALIDATORS_NAME): | ||
| return [] | ||
|
|
||
| artifacts = [] | ||
| for key, (requested_attrs, validator) in ctx.attrs.attrs_validators.items(): | ||
| if type(validator) == "tuple": | ||
| validator, validator_args = validator | ||
| else: | ||
| validator = validator | ||
| validator_args = [] | ||
|
|
||
| output = ctx.actions.declare_output(key) | ||
| ctx.actions.run( | ||
| cmd_args([ | ||
| validator[RunInfo], | ||
| _build_attr_json_args(ctx, key, requested_attrs), | ||
| output.as_output(), | ||
| ] + validator_args), | ||
| category = "attrs_validator", | ||
| identifier = key, | ||
| ) | ||
| artifacts.append(output) | ||
|
|
||
| return artifacts | ||
|
|
||
| def _build_attr_json_args(ctx: AnalysisContext, key: str, requested_attrs: list[str]): | ||
| attr_args = {} | ||
| missing_attrs = [] | ||
| for attr in requested_attrs: | ||
| if attr == "configured_target_label": | ||
| attr_args["configured_target_label"] = ctx.label.configured_target() | ||
| elif attr == "target_label": | ||
| attr_args["target_label"] = ctx.label.raw_target() | ||
| elif hasattr(ctx.attrs, attr): | ||
| attr_args[attr] = getattr(ctx.attrs, attr) | ||
| else: | ||
| missing_attrs.append(attr) | ||
|
|
||
| if missing_attrs: | ||
| fail("The following attrs are not available on {}: {}".format( | ||
| ctx.label, | ||
| ", ".join(sorted(missing_attrs)), | ||
| )) | ||
|
|
||
| attr_args = ctx.actions.write_json( | ||
| "{}-attrs.json".format(key), | ||
| attr_args, | ||
| with_inputs = True, | ||
| ) | ||
|
|
||
| return attr_args |