Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP - Dynamic dependencies for Haskell (discussion) #19

Draft
wants to merge 17 commits into
base: main
Choose a base branch
from
Draft

WIP - Dynamic dependencies for Haskell (discussion) #19

wants to merge 17 commits into from

Conversation

avdv
Copy link
Contributor

@avdv avdv commented Sep 17, 2024 •
edited
Loading

  • Pass correct rpath origin setting to linker on Darwin
  • Add cxx_merge_cpreprocessors_actions function with AnalysisActions parameter
  • Add script to generate target metadata for Haskell
  • Add ghc wrapper script which writes ABI hash and a deps file
  • Add is_haskell_boot helper function
  • Add HaskellToolchainLibrary provider
  • Add haskell_toolchain_library rule
  • Add generate_target_metadata and ghc_wrapper tool targets
  • make compiler_flags be of arg type (#34)
  • Add scripts to haskell rules
  • Allow to declare dependencies for haskell sources manually
  • Add get_source_prefixes helper function
  • Make ghci_lib_path optional in template processor script
  • Add attributes to haskell rules
  • Support HaskellToolchainLibs for ide BXL
  • Make cc toolchain tools optional
  • Determine haskell dependencies and compile modules according to the dependency graph

IMPORTANT: Please don't raise pull requests here, but at
facebook/buck2.

NOTE: this is a PR to get the discussion started on how to incorporate our changes into upstream.

I'll raise a PR at the buck2 repo soonish.

These changes requires a few GHC patches:

avdv and others added 17 commits September 17, 2024 11:07
@avdv
Pass correct rpath origin setting to linker on Darwin
510e85d 
Similar to D54346421
@avdv
Add cxx_merge_cpreprocessors_actions function with `AnalysisActions…
918cc09 
…` parameter

This is going to be useful with new dynamic action rules.
@avdv
Add script to generate target metadata for Haskell
5c76460
@avdv
Add ghc wrapper script which writes ABI hash and a deps file
1c0f3c8
@avdv
Add is_haskell_boot helper function
5c073fe
@avdv
Add HaskellToolchainLibrary provider
04bc389 
This is used to track libraries that are provided by the haskell toolchain (e.g. by Nix) in the `deps`
attribute of Haskell rules.
@avdv
Add haskell_toolchain_library rule
28821ff
@avdv
Add generate_target_metadata and ghc_wrapper tool targets
15df14c
@wavewave @avdv
make compiler_flags be of arg type (#34)
cf6e340 
compiler_flags often needs macro like $(location :target).
@aherrmann @avdv
Add scripts to haskell rules
a43ba22
@avdv
Allow to declare dependencies for haskell sources manually
9e563a9
@avdv
Add get_source_prefixes helper function
0175c44
@avdv
Make ghci_lib_path optional in template processor script
8915ca0
@avdv
Add attributes to haskell rules
92486a8 
- `external_tools`: pass executables called from Haskell compiler during preprocessing or compilation
- `srcs_envs`: pass individual run-time env for each source compilation
- `use_argsfile_at_link`: use response file at linking
@avdv
Support HaskellToolchainLibs for ide BXL
d9af4ce
@avdv
Make cc toolchain tools optional
f1b8753
@avdv @wavewave @aherrmann
Determine haskell dependencies and compile modules according to the d…
bb7b557 
…ependency graph

This commit comprises all of the changes needed to use meta data from the Haskell compiler (a JSON file gathered with `ghc -M`) and use that inside
of dynamic actions to create module compilation actions, including tracking cross-package dependencies and handling template haskell usage accordingly.

This also allows us to put sources into different sub-directories.

Co-authored-by: Ian-Woo Kim <ianwookim@gmail.com>
Co-authored-by: Andreas Herrmann <andreas.herrmann@tweag.io>
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 17, 2024
@avdv avdv changed the title WIP - Pass correct rpath origin setting to linker on Darwin (discussion) WIP - Dynamic dependencies for Haskell (discussion) Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@avdv @facebook-github-bot @wavewave @aherrmann