Skip to content

Commit

Permalink
Port cra.sh development task to javascript
Browse files Browse the repository at this point in the history
Use absolute path when generating .tgz path
  • Loading branch information
ianschmitz committed Nov 8, 2017
1 parent 9484ef9 commit 10128ad
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions tasks/cra.js
Original file line number Diff line number Diff line change
Expand Up @@ -65,10 +65,8 @@ const scriptsFileName = cp
.execSync(`npm pack`, { cwd: reactScriptsDir })
.toString()
.trim();
// CRA can run into issues if the .tgz path is absolute (especially on Windows)
// Use a relative path to be safe
const scriptsPath = path.join(
'..',
rootDir,
'packages',
'react-scripts',
scriptsFileName
Expand Down

0 comments on commit 10128ad

Please sign in to comment.