Support passing scoped package names to --scripts-version arg (#826)

* Support passing scoped package names to --scripts-version arg * Factor out bitwise operator in indexOf test * Comment on stripping only version or tag from package name arg
facebook · Oct 11, 2016 · 1359cc4 · 1359cc4
1 parent 3539d04
commit 1359cc4
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/packages/create-react-app/index.js b/packages/create-react-app/index.js
@@ -152,10 +152,11 @@ function getInstallPackage(version) {
 
 // Extract package name from tarball url or path.
 function getPackageName(installPackage) {
-  if (~installPackage.indexOf('.tgz')) {
+  if (installPackage.indexOf('.tgz') > -1) {
     return installPackage.match(/^.+\/(.+)-.+\.tgz$/)[1];
-  } else if (~installPackage.indexOf('@')) {
-    return installPackage.split('@')[0];
+  } else if (installPackage.indexOf('@') > 0) {
+    // Do not match @scope/ when stripping off @version or @tag
+    return installPackage.charAt(0) + installPackage.substr(1).split('@')[0];
   }
   return installPackage;
 }