Skip to content

Commit

Permalink
use cp instead of npm link
Browse files Browse the repository at this point in the history
  • Loading branch information
viankakrisna committed Sep 10, 2017
1 parent 44cfbcc commit 4bb418b
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 11 deletions.
14 changes: 7 additions & 7 deletions tasks/e2e-kitchensink.sh
Original file line number Diff line number Diff line change
Expand Up @@ -164,10 +164,10 @@ npm install test-integrity@^2.0.1
cd "$temp_app_path/test-kitchensink"

# Link to our preset
npm link "$root_path"/packages/babel-preset-react-app
cp -r "$root_path"/packages/babel-preset-react-app node_modules

# Link to test module
npm link "$temp_module_path/node_modules/test-integrity"
cp -r "$temp_module_path/node_modules/test-integrity" node_modules

# Test the build
REACT_APP_SHELL_ENV_MESSAGE=fromtheshell \
Expand Down Expand Up @@ -225,13 +225,13 @@ npm unlink "$root_path"/packages/babel-preset-react-app
echo yes | npm run eject

# ...but still link to the local packages
npm link "$root_path"/packages/babel-preset-react-app
npm link "$root_path"/packages/eslint-config-react-app
npm link "$root_path"/packages/react-dev-utils
npm link "$root_path"/packages/react-scripts
cp -r "$root_path"/packages/babel-preset-react-app node_modules
cp -r "$root_path"/packages/eslint-config-react-app node_modules
cp -r "$root_path"/packages/react-dev-utils node_modules
cp -r "$root_path"/packages/react-scripts node_modules

# Link to test module
npm link "$temp_module_path/node_modules/test-integrity"
cp -r "$temp_module_path/node_modules/test-integrity" node_modules

# Test the build
REACT_APP_SHELL_ENV_MESSAGE=fromtheshell \
Expand Down
8 changes: 4 additions & 4 deletions tasks/e2e-simple.sh
Original file line number Diff line number Diff line change
Expand Up @@ -309,10 +309,10 @@ verify_module_scope
echo yes | npm run eject

# ...but still link to the local packages
npm link "$root_path"/packages/babel-preset-react-app
npm link "$root_path"/packages/eslint-config-react-app
npm link "$root_path"/packages/react-dev-utils
npm link "$root_path"/packages/react-scripts
cp -r "$root_path"/packages/babel-preset-react-app node_modules
cp -r "$root_path"/packages/eslint-config-react-app node_modules
cp -r "$root_path"/packages/react-dev-utils node_modules
cp -r "$root_path"/packages/react-scripts node_modules

# Test the build
npm run build
Expand Down

0 comments on commit 4bb418b

Please sign in to comment.