update comment about json-loader to explain why it is needed

facebook · Jan 16, 2018 · 74d3202 · 74d3202
1 parent f7100df
commit 74d3202
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/packages/react-scripts/config/webpack.config.dev.js b/packages/react-scripts/config/webpack.config.dev.js
@@ -148,8 +148,8 @@ module.exports = {
         // match the requirements. When no loader matches it will fall
         // back to the "file" loader at the end of the loader list.
         oneOf: [
-          // This is included by default, but when we add .json to eslint-loader
-          // test regex the compiler fails to recognize json files.
+          // Necessary because we add .json test in eslint-loader
+          // https://webpack.js.org/guides/migrating/#json-loader-is-not-required-anymore
           {
             test: /\.json$/,
             loader: require.resolve('json-loader'),

diff --git a/packages/react-scripts/config/webpack.config.prod.js b/packages/react-scripts/config/webpack.config.prod.js
@@ -157,8 +157,8 @@ module.exports = {
         // match the requirements. When no loader matches it will fall
         // back to the "file" loader at the end of the loader list.
         oneOf: [
-          // This is included by default, but when we add .json to eslint-loader
-          // test regex the compiler fails to recognize json files.
+          // Necessary because we add .json test in eslint-loader
+          // https://webpack.js.org/guides/migrating/#json-loader-is-not-required-anymore
           {
             test: /\.json$/,
             loader: require.resolve('json-loader'),