Skip to content

Commit

Permalink
Relax React dep requirements
Browse files Browse the repository at this point in the history
  • Loading branch information
@gaearon
gaearon committed Aug 28, 2017
1 parent 2cbb760 commit cc2e270
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions packages/react-error-overlay/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,8 @@
"babel-code-frame": "6.22.0",
"babel-runtime": "6.26.0",
"html-entities": "1.2.1",
"react": "^15.5.4",
"react-dom": "^15.5.4",
"react": "^15 || ^16",
"react-dom": "^15 || ^16",
"settle-promise": "1.0.0",
"source-map": "0.5.6"
},
Expand Down

1 comment on commit cc2e270

@thebuilder
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @gaearon

This change causes yarn to throw a warning:

Lockfile has incorrect entry for "react@^15 || ^16". Ignoring it.

I'm guessing it's illegal to use || in a dependency definition?
Should it be moved to peerDependencies, and with a locked version in devDependencies?

Also not sure if you can omit the minor and patch version from the definition?

Please sign in to comment.