Comment on stripping only version or tag from package name arg

facebook · Oct 3, 2016 · d9ed896 · d9ed896
1 parent 33f9731
commit d9ed896
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/packages/create-react-app/index.js b/packages/create-react-app/index.js
@@ -152,9 +152,10 @@ function getInstallPackage(version) {
 
 // Extract package name from tarball url or path.
 function getPackageName(installPackage) {
-  if (installPackage.indexOf('.tgz') > 0) {
+  if (installPackage.indexOf('.tgz') > -1) {
     return installPackage.match(/^.+\/(.+)-.+\.tgz$/)[1];
   } else if (installPackage.indexOf('@') > 0) {
+    // Do not match @scope/ when stripping off @version or @tag
     return installPackage.charAt(0) + installPackage.substr(1).split('@')[0];
   }
   return installPackage;