-
-
Notifications
You must be signed in to change notification settings - Fork 26.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unnecessary logo.svg file from template. #106
Comments
I think it's less about showing a logo, and more about showcasing to a new user how they might be able to use images in React. Most of the template code is there for that purpose. |
The point was to demonstrate how importing images works in Webpack (which is not obvious to anyone who has never worked with it). I think people will try to use strings in |
Makes a lot of sense. You guys have convinced me =] |
Yes, I saw it first time after creating my first create-react-app! |
Fix Jest snapshot CSS Module class names, add CSS Module class name template as a configuration option. Closes facebook#106 and facebook#97.
I think that having an image file on the project template is just cumbersome, since virtually every user will have to delete it.
Other famous CLI tools for creating projects (such as rails or ember-cli) also display images on the first welcome screen, but neither add the actual image file to the generated project.
The text was updated successfully, but these errors were encountered: