Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary logo.svg file from template. #106

Closed
cassiozen opened this issue Jul 22, 2016 · 4 comments
Closed

Remove unnecessary logo.svg file from template. #106

cassiozen opened this issue Jul 22, 2016 · 4 comments

Comments

@cassiozen
Copy link

I think that having an image file on the project template is just cumbersome, since virtually every user will have to delete it.

Other famous CLI tools for creating projects (such as rails or ember-cli) also display images on the first welcome screen, but neither add the actual image file to the generated project.

@eanplatter
Copy link
Contributor

I think it's less about showing a logo, and more about showcasing to a new user how they might be able to use images in React. Most of the template code is there for that purpose.

@gaearon
Copy link
Contributor

gaearon commented Jul 22, 2016

The point was to demonstrate how importing images works in Webpack (which is not obvious to anyone who has never worked with it). I think people will try to use strings in src directly if they don't see this example, and will be frustrated that this doesn't work. Do you have an alternative way of explaining this pattern to users? Perhaps, some lint rules could help? Also, I'm curious: how often do you create new apps?

@cassiozen
Copy link
Author

(...) showcasing to a new user how they might be able to use images in React.
I think people will try to use strings in src directly if they don't see this example

Makes a lot of sense. You guys have convinced me =]

@kasperpeulen
Copy link
Contributor

The point was to demonstrate how importing images works in Webpack (which is not obvious to anyone who has never worked with it).

Yes, I saw it first time after creating my first create-react-app!

grengojbo pushed a commit to grengojbo/es6-react-scripts that referenced this issue Jun 6, 2018
Fix Jest snapshot CSS Module class names, add CSS Module class name template as a configuration option. Closes facebook#106 and facebook#97.
@lock lock bot locked and limited conversation to collaborators Jan 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants