Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot resolve module 'babel-runtime/*' #1421

Closed
scholtzm opened this issue Jan 20, 2017 · 8 comments
Closed

Cannot resolve module 'babel-runtime/*' #1421

scholtzm opened this issue Jan 20, 2017 · 8 comments

Comments

@scholtzm
Copy link
Contributor

This is probably more of a question than a bug report.

Recently, out of nowhere, I started having issues with missing babel-runtime:

So I checked the last commit (which was a while ago) and it passed all commit checks:
image

Now, if I do clean setup, clone the repo and try to build it, it fails. The only thing that might have changed during this time are dependencies (semantic updates).

Adding babel-runtime to my dependencies fixes this issue but I'm not sure if this is the right way to go about it?

@scholtzm scholtzm changed the title Issues with missing babel-runtime Cannot resolve module 'babel-runtime/*' Jan 20, 2017
@gaearon
Copy link
Contributor

gaearon commented Feb 9, 2017

This is weird. Is it still reproducible? Can you provide exact instructions to reproduce it?

@scholtzm
Copy link
Contributor Author

scholtzm commented Feb 9, 2017

I'll test this out again in the next day or two.

@scholtzm
Copy link
Contributor Author

scholtzm commented Feb 9, 2017

@gaearon I just removed babel-runtime and it builds now without it. Not sure what exactly was the issue but I guess we can close this now.

🤔

@scholtzm scholtzm closed this as completed Feb 9, 2017
@gaearon
Copy link
Contributor

gaearon commented Feb 9, 2017

Sometimes it's healthier not to know.

@andreineculau
Copy link

andreineculau commented Feb 9, 2017 via email

@gaearon
Copy link
Contributor

gaearon commented Feb 9, 2017

Maybe some module (semantic-ui-react judging by first post's CI log) that depends on it forgets to declare a dependency. In this case whether the dependency exists or not depends on other project dependencies and is non-deterministic. Have you raised an issue with the library causing this, like semantic-ui-react?

@levithomason
Copy link

This is fixed in semantic-ui-react@0.64.8.

@gaearon
Copy link
Contributor

gaearon commented Feb 11, 2017

Awesome, thanks for reporting back.

@lock lock bot locked and limited conversation to collaborators Jan 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants