-
-
Notifications
You must be signed in to change notification settings - Fork 26.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Public Beta Testing of react-scripts@1.0.0 #2172
Comments
Looks like some it could be a Yarn bug? cc @bestander
but I see
installed instead. Try running |
@gaearon could it be the |
per the semver spec:
therefore, |
Huh. I guess Lerna |
Yep, it’s completely broken. 😄 I wish I knew that before. |
Published a new canary with fixed npm package, more visual fixes to overlays, better build messages, and smaller post eject code size. Please give it a try! It’s close to a release candidate. |
Been running a custom fork of (what used to be) 0.10 in production for a month or two now (ever since the webpack 2 PR) and haven't run into any bugs/issues yet! |
Just published an RC as the last canary. |
Just ran an upgrade and everything went smoothly. Just deployed to production too, everything running fine 🤘 |
The testing-workshop tests all passed without a hitch! And the app still looks perfect (both dev and prod versions)! 🚀 🚢 |
New canary caught me on some none-existed imported values. Fixing that led me to successfull deployment to prod! |
Feedback.
«rule keywords» was confusing for me for 15 seconds. Word «rule» is confusing. What rule? I am not aware of any rules. This project hides config complexity, so a novice may not get what this message about. We can make «react/jsx-no-undef» clickable , but maybe it's to much 😺 |
@gaearon This is awesome!!! Thank you for adding that. This is absolutely beautiful now: |
@rogovdm I agree, changed to just |
Updating an existing project - this is working great for me so far. Thanks to you and your team, @gaearon! |
I get this warning now too, and can't figure out how to get rid of it. It's not documented in the README, and Googling around for this didn't turn up anything useful. |
Where do you get it? You have not specified your editor, plugin, whether you use global ESLint for it, etc. |
I'll close this issue since 1.0 is out but please file new ones if something is confusing! |
Nuclide, latest version (of Atom as well). No global eslint installed.
|
That's not the right fix, you're still running wrong versions of plugins. This silences this warning but you'll see more breakage in the future. I suggest fixing the root cause rather than symptoms. Let's try this:
I think that should help but let me know if not, and we can debug more. |
That did the trick! I noticed that .eslintrc changes would get recognized by closing a file and reopening it, but in this case, quitting Atom entirely was required. |
Yea. Since it loads rules into memory, their code sticks around in the require cache even after closing the file. |
Hi gaearon & all, I'm getting the following flow error in both Nuclide and VS Code. I've tried the above steps you recommended several times but no joy. Also tried deleting node_modules and reinstalling. identifier Doesn't happen in React Scripts v0.9.x; only when upgrading to 1.0.2-3 In Nuclide 0.228.0:
In VS Code 1.12.2:
Here are my .eslintrc and .flowconfig settings: devDependancies:
Any suggestions much appreciated! |
The error is because Flow is trying to typecheck the ESLint plugin. |
Ahh ok that worked, thanks very much :) |
@gaearon I don't have global ESlint, and I'm using VSCode, and I have this warning in both when working locally and the Tarvic CI is breaking because of this same warning : |
@zerubeus The public testing has finished a long time ago so this is not an appropriate issue. Please file a new issue with an example project reproducing this. Thanks! |
Known Issues:
Updates:
require.ensure()
warning.require.ensure()
.Today I invite you to help us beta test
react-scripts@1.0.0
for a few days before the public release.It used to be called
0.10
but we figured there’s enough improvements to make it 1.0.To create a new app with it, run:
To upgrade an existing app, replace
"react-scripts": "0.9.5"
in yourpackage.json
with:and run
npm install
(oryarn
).There is no changelog yet, but you can open the milestone to get a sense of included changes.
A few highlights:
import()
(Add support for dynamic import & disable require.ensure #1538)env
files (Feature/different env config files #1343 #1344)BROWSER
variable (Support node scripts in BROWSER #1590)src
run now (Only run tests in <rootDir>/src (#544) #1808)public
folder refreshes the page (Enable page reloading for files inpublic/
#1546)There are a few more changes we plan to get into 1.0.0, but this should be enough the first public testing.
Please report any issues you bump into in this thread. We want this release to be as solid as possible, even though it’s unlikely we’ll keep it unreleased for much longer.
Big thanks to all the contributors. This will be our biggest release yet.
The text was updated successfully, but these errors were encountered: