Add support for dynamic import & disable require.ensure #1538
Conversation
Timer
changed the title
package.json
Outdated
| @@ -11,7 +11,7 @@ | |||
| "test": "node packages/react-scripts/scripts/test.js --env=jsdom" | |||
| }, | |||
| "devDependencies": { | |||
| "babel-eslint": "6.1.2", | |||
| "babel-eslint": "7.1.0", | |||
There was a problem hiding this comment.
latest is 7.1.1, could as well use that.
| "eslint-plugin-jsx-a11y": "2.2.2", | ||
| "eslint-plugin-react": "6.3.0", | ||
| "babel-eslint": "7.1.0", | ||
| "eslint": "3.8.1", |
| "babel-eslint": "7.1.0", | ||
| "eslint": "3.8.1", | ||
| "eslint-config-react-app": "0.5.1", | ||
| "eslint-plugin-flowtype": "2.21.0", |
| "eslint": "3.8.1", | ||
| "eslint-config-react-app": "0.5.1", | ||
| "eslint-plugin-flowtype": "2.21.0", | ||
| "eslint-plugin-import": "2.0.1", |
|
I tried to keep versions near https://github.com/facebookincubator/create-react-app/blob/master/packages/eslint-config-react-app/package.json since typically we employ exact versions (I forget why it was relaxed in that package); since this is strictly for development tho it might not hurt to bump them. Same reasoning for #1544. |
|
Yes, that is the reason I was hoping to have them as the latest version, to avoid the number of duplicate dependencies package managers have to install, like the issues |
|
note: these deps are only when you're developing on this package locally, it has no effect on create-react-app installs. We can prob bump them. |
|
Oh, okay 👍 |
|
|
|
@Timer Sorry if this is newbie question but this change isn't reflected in the current npm package right? |
|
No, this is tagged as 0.10.0:
The last released version is 0.9.0 (you can check the releases page). |
|
@gaearon Got it! Thanks! |
* Disable require.ensure * Replace require.ensure with import * Add babel plugin for parsing import() * Get the default * Upgrade babel-eslint to support dynamic import * Fix dep * Update deps
* Disable require.ensure * Replace require.ensure with import * Add babel plugin for parsing import() * Get the default * Upgrade babel-eslint to support dynamic import * Fix dep * Update deps
* Disable require.ensure * Replace require.ensure with import * Add babel plugin for parsing import() * Get the default * Upgrade babel-eslint to support dynamic import * Fix dep * Update deps # Conflicts: # package.json # packages/babel-preset-react-app/package.json # packages/babel-preset-react-cy-app/index.js # packages/react-cy-scripts/config/webpack.config.dev.js # packages/react-cy-scripts/config/webpack.config.prod.js
|
Please help beta test the new version that includes this change! |
This PR enables babel syntax support for
import()and disables require.ensure support within webpack.It also updates the required internal files.