Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

react-error-overlay: uncaught typeerror on using right/left arrow #2231

Closed
Gandem opened this issue May 19, 2017 · 7 comments
Closed

react-error-overlay: uncaught typeerror on using right/left arrow #2231

Gandem opened this issue May 19, 2017 · 7 comments

Comments

@Gandem
Copy link
Contributor

Gandem commented May 19, 2017

Hello !

First of all thanks a lot for the upgrade and the hard work, create-react-app is completely awesome 😄 !

This issue was discovered when updating to react-scripts@1.0.0

Description

On launching an empty app created with create-react-app, and using right/left arrow on the keyboard (when no overlay error is present) it logs an error in the console:

Uncaught TypeError: Cannot read property 'error' of undefined
    at renderErrorByIndex (overlay.js:66)
    at switchError (overlay.js:86)
    at shortcutHandler (overlay.js:145)
    at keyHandler (shortcuts.js:17)

Reproducible Demo

I could reproduce this error on a new react project created with create-react-app, as well as old projects I upgraded.

For info, I'm on Mac OSX Sierra on Chrome 57.

I would be glad to send a Pull Request and work on this issue, if someone could give me some hints to what's actually happening on here !

@Gandem Gandem changed the title react-error-overlay: uncaught typeerror on clicking right/left arrow react-error-overlay: uncaught typeerror on using right/left arrow May 19, 2017
@gaearon
Copy link
Contributor

gaearon commented May 19, 2017

Thanks! I’ll take a look later today but if you find a quick fix send it our way.

Timer added a commit to Timer/create-react-app that referenced this issue May 19, 2017
@Timer
Copy link
Contributor

Timer commented May 19, 2017

Fixed in #2238

@Timer Timer closed this as completed May 19, 2017
@gaearon
Copy link
Contributor

gaearon commented May 19, 2017

react-scripts@1.0.1 should be out with a fix.
Can you please verify it helps?

@Gandem
Copy link
Contributor Author

Gandem commented May 19, 2017

Just upgraded to react-scripts@1.0.1 on some of my projects, and it worked perfectly. Thanks a lot 🙌 !

@kobens
Copy link

kobens commented May 22, 2017

The fix doesn't seem to be working in react-scripts@1.0.3. I can see it's there, but when I look at the react-error-overlay package in my node_modules folder it has the correct version number (1.0.3), however, the fix is not present in the overlay.js file.

@gaearon
Copy link
Contributor

gaearon commented May 22, 2017

Oops, my fault. Will publish 1.0.4 soon.

@gaearon
Copy link
Contributor

gaearon commented May 22, 2017

Should be fixed in 1.0.4 (just published).

@lock lock bot locked and limited conversation to collaborators Jan 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants