Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typo in Documentation/react-scripts/on-ci-server/travis #2713

Closed
zeel opened this issue Jul 3, 2017 · 2 comments
Closed

typo in Documentation/react-scripts/on-ci-server/travis #2713

zeel opened this issue Jul 3, 2017 · 2 comments

Comments

@zeel
Copy link
Contributor

zeel commented Jul 3, 2017

I am using travis as my CI server and as per README( link ) used following script for .travis.yml file

language: node_js
node_js:
  - 6
cache:
  directories:
    - node_modules
script:
  - npm test
  - npm run build

The problem is with the order of commands. When running tests, it won't be able to find .css files as they are created in npm run build step.

I think following would be correct .travis.yml file.

language: node_js
node_js:
  - 6
cache:
  directories:
    - node_modules
script:
  - npm run build
  - npm test

Let me know if I can open PR for this.

@gaearon
Copy link
Contributor

gaearon commented Jul 3, 2017

Sounds good.

@zeel
Copy link
Contributor Author

zeel commented Jul 5, 2017

@gaearon I have opened PR for this.

@Timer Timer closed this as completed in 3ffad55 Jul 13, 2017
JohnNilsson referenced this issue in JohnNilsson/create-react-app-typescript Aug 9, 2017
morgs32 pushed a commit to BrickworkSoftware/create-react-app that referenced this issue Sep 1, 2017
JohnNilsson referenced this issue in JohnNilsson/create-react-app-typescript Sep 9, 2017
kasperpeulen pushed a commit to kasperpeulen/create-react-app that referenced this issue Sep 24, 2017
swengorschewski referenced this issue in swengorschewski/cra-typescript-electron Oct 16, 2017
@lock lock bot locked and limited conversation to collaborators Jan 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants