-
-
Notifications
You must be signed in to change notification settings - Fork 26.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
State is not preserved when hot reloading #328
Comments
Sorry, just seen #93 – does this mean React HMR is not enabled yet? Will close this issue if so |
Yea, no plans to enable it until it’s more stable. (Requires work both on Webpack and my side, and I didn’t have time for this yet.) |
Cool, thanks Dan. Great work on this, makes a big difference to the mental overhead of trying out a new idea or whatever... |
Thanks! |
Would you consider a PR to add this as an experimental feature or do you want to avoid things like that? Unfortunately no HMR means this isn't that practical for me to use on my current project, as the state is annoying to set up every time :( |
No, PR won’t help because, as I said, the underlying tools are not stable enough to be the default. |
Thought so – will keep an eye on the tool and hopefully at some point HMR On 2 August 2016 at 19:40, Dan Abramov notifications@github.com wrote:
|
I would expect the app state to be preserved when hot reloading occurs, but this doesn't seem to be the case – the state always resets to the initial state.
Simple reproduction test case: https://github.com/tomduncalf/create-react-app-state-hmr-bug
The text was updated successfully, but these errors were encountered: