-
-
Notifications
You must be signed in to change notification settings - Fork 26.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Created app has wrong favicon "sizes" value in the manifest file, which results in console error. #3284
Comments
The included |
@ryansully yes, you are right, it's 64x64. My IDE wrongly showed it to be 16x16. My bad. |
@ryansully have you signed the CLA here https://code.facebook.com/cla to get your PR approved? |
That's odd, I've signed it and contributed before, should I sign again? |
Actually, #3287 has the CLA Signed label: PR should be ready to go. |
I see this warning but icon size is 64x64 how remove this warning? |
@camux, in your app, go to |
Is this a bug report?
Yes
Can you also reproduce the problem with npm 4.x?
Did not try. Doesn't seem to be related to that.
Which terms did you search for in User Guide?
I didn't.
Environment
node -v
: v8.7.0npm -v
: 5.5.1yarn --version
(if you use Yarn):npm ls react-scripts
(if you haven’t ejected):Then, specify:
macOS 10.13
Chrome 61
Steps to Reproduce
Error while trying to use the following icon from the Manifest: http://localhost:3000/favicon.ico (Resource size is not correct - typo in the Manifest?) Site cannot be installed: icon downloaded from the manifest was empty or corrupted
Expected Behavior
Should have searched for
144x144
image, where it would fail if we fix the size now.Actual Behavior
Console error.
Reproducible Demo
The text was updated successfully, but these errors were encountered: