Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set webpack-uglify-plugin ecma support based on browserlist #3748

Closed
viankakrisna opened this issue Jan 11, 2018 · 2 comments
Closed

set webpack-uglify-plugin ecma support based on browserlist #3748

viankakrisna opened this issue Jan 11, 2018 · 2 comments
Projects

Comments

@viankakrisna
Copy link
Contributor

viankakrisna commented Jan 11, 2018

given that #3618 and #3743 and #3644 recently merged to the next branch, we need a way to parse browserlist for uglifyjs es5-only support. This is done to ensure that no es6 dependency leaks through an es5 only environment.

Note:
need to verify that #2650 still works

@Timer
Copy link
Contributor

Timer commented Jan 11, 2018

We have a note [not issue] for tracking this here: https://github.com/facebookincubator/create-react-app/projects/3.

@Timer Timer added this to Blocker in 2.0 Jan 13, 2018
@Timer
Copy link
Contributor

Timer commented Jan 14, 2018

This setting doesn't actually restrict anything (very few places), so we might as well let everything parse.
We're also compiling node_modules now, so there's that.

6f05355

@Timer Timer closed this as completed Jan 14, 2018
2.0 automation moved this from Blocker to Ready Jan 14, 2018
@lock lock bot locked and limited conversation to collaborators Jan 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
No open projects
2.0
  
Ready
Development

No branches or pull requests

3 participants