use uglifyjs-webpack-plugin v1 #3618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Timer
added
tag: enhancement
tag: internal
and removed
tag: enhancement
tag: internal
labels
|
Oops, accidentally merged this to master. You can find this in |
Timer
pushed a commit
that referenced
this pull request
Jan 11, 2018
Timer
pushed a commit
to Timer/create-react-app
that referenced
this pull request
Jan 11, 2018
Timer
pushed a commit
to Timer/create-react-app
that referenced
this pull request
Jan 13, 2018
gaearon
pushed a commit
that referenced
this pull request
Jan 13, 2018
Timer
pushed a commit
that referenced
this pull request
Jan 14, 2018
gaearon
pushed a commit
that referenced
this pull request
Jan 14, 2018
gaearon
pushed a commit
that referenced
this pull request
Jan 14, 2018
gaearon
pushed a commit
that referenced
this pull request
Jan 14, 2018
gaearon
pushed a commit
that referenced
this pull request
Jan 14, 2018
Timer
pushed a commit
to Timer/create-react-app
that referenced
this pull request
Jan 15, 2018
|
Is there any chance of this getting into a 1.1.2 (or similar) release? This will fix a lot of the minifying problems. |
|
No, this will not be released in a 1.1.2 release. Sorry! This is not a minifying problem, but as that link explains it's a problem with the libraries you're importing. |
akstuhl
pushed a commit
to akstuhl/create-react-app
that referenced
this pull request
Mar 15, 2018
zmitry
pushed a commit
to zmitry/create-react-app
that referenced
this pull request
Sep 30, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as quoted by the readme https://github.com/webpack-contrib/uglifyjs-webpack-plugin:
The v1 is released on October, so I think it's mature enough to switch to v1 in CRA? or do we want to wait for webpack 4?
Pro:
This allows us to use uglify-es and access to parallel and cache options. Hence improving our build speed.
Con:
I haven't test it yet, but maybe this will break our parsing of uglify error #2650