Loosen Babel preset to use browserslist #3770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Timer
changed the title
existentialism
approved these changes
Jan 13, 2018
|
Meh, why not? Commits can be reverted (and follow-up PRs made) -- this will be fun to play with in the meantime.
|
🚀
gaearon
reviewed
Jan 13, 2018
| ]; | ||
| appPackage.browserslist = { | ||
| development: ['chrome', 'firefox', 'edge'].map( | ||
| browser => `last 2 ${browser} versions` |
There was a problem hiding this comment.
Why this change? Does this correspond to any specific list we use elsewhere?
There was a problem hiding this comment.
Never mind, I got it.
Wish there was a shorter way to write this.
Maybe something like >5% is equivalent?
There was a problem hiding this comment.
I couldn't find a magic percent -- and I didn't want to discriminate browsers.
|
Can you describe how this works in more detail? In particular, what happens if I write ES6 code and then set |
|
Or do we use new Uglify now? |
gaearon
pushed a commit
that referenced
this pull request
Jan 13, 2018
* Provide better defaults * Let babel determine features to compile * meh * Remove setting of BABEL_ENV * Revert "Remove setting of BABEL_ENV" This reverts commit ee2db70. * Set browsers to ie9
Timer
added a commit
that referenced
this pull request
Jan 14, 2018
* Provide better defaults * Let babel determine features to compile * meh * Remove setting of BABEL_ENV * Revert "Remove setting of BABEL_ENV" This reverts commit ee2db70. * Set browsers to ie9
gaearon
pushed a commit
that referenced
this pull request
Jan 14, 2018
* Provide better defaults * Let babel determine features to compile * meh * Remove setting of BABEL_ENV * Revert "Remove setting of BABEL_ENV" This reverts commit ee2db70. * Set browsers to ie9
gaearon
pushed a commit
that referenced
this pull request
Jan 14, 2018
* Provide better defaults * Let babel determine features to compile * meh * Remove setting of BABEL_ENV * Revert "Remove setting of BABEL_ENV" This reverts commit ee2db70. * Set browsers to ie9
gaearon
pushed a commit
that referenced
this pull request
Jan 14, 2018
* Provide better defaults * Let babel determine features to compile * meh * Remove setting of BABEL_ENV * Revert "Remove setting of BABEL_ENV" This reverts commit ee2db70. * Set browsers to ie9
gaearon
pushed a commit
that referenced
this pull request
Jan 14, 2018
* Provide better defaults * Let babel determine features to compile * meh * Remove setting of BABEL_ENV * Revert "Remove setting of BABEL_ENV" This reverts commit ee2db70. * Set browsers to ie9
Timer
added a commit
to Timer/create-react-app
that referenced
this pull request
Jan 15, 2018
* Provide better defaults * Let babel determine features to compile * meh * Remove setting of BABEL_ENV * Revert "Remove setting of BABEL_ENV" This reverts commit ee2db70. * Set browsers to ie9
akstuhl
pushed a commit
to akstuhl/create-react-app
that referenced
this pull request
Mar 15, 2018
* Provide better defaults * Let babel determine features to compile * meh * Remove setting of BABEL_ENV * Revert "Remove setting of BABEL_ENV" This reverts commit ee2db70. * Set browsers to ie9
zmitry
pushed a commit
to zmitry/create-react-app
that referenced
this pull request
Sep 30, 2018
* Provide better defaults * Let babel determine features to compile * meh * Remove setting of BABEL_ENV * Revert "Remove setting of BABEL_ENV" This reverts commit ee2db70. * Set browsers to ie9
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the
ie 9target andforceAllTransformssince we're dropping IE9 support by default.We want to allow target browsers to be configurable via the
browserslistkey inpackage.json.This also enables
useBuiltInsfor smaller bundles.I've also adjusted the defaults we generate for a more ergonomic development experience.
There's still no story for users upgrading from * -> 2.x (it'd use browserlist defaults currently).