Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot GET Url Paths that have a Dot in Them #387

Closed
scottfr opened this issue Aug 6, 2016 · 4 comments
Closed

Cannot GET Url Paths that have a Dot in Them #387

scottfr opened this issue Aug 6, 2016 · 4 comments
Labels
issue: proposal tag: underlying tools
Milestone
0.2.3

Comments

@scottfr
Copy link

scottfr commented Aug 6, 2016

The dev server cannot successfully load paths that have a period in them:

For instance, this works fine:

http://localhost:3000/page/test

But this, fails with the error 'Cannot GET /page/test.com':

http://localhost:3000/page/test.com
@gaearon
Copy link
Contributor

gaearon commented Aug 6, 2016

This seems hardcoded into connect-history-api-fallback here but it’s not very relevant in our case. Maybe you would like to submit a PR to that repo to make that configurable? If it gets merged, we could use that option.

@TuckerWhitehouse
Copy link

https://github.com/bripkens/connect-history-api-fallback#disabledotrule

@gaearon
Copy link
Contributor

gaearon commented Aug 11, 2016

Nice! I’ll keep this open to remember to update and use that new option.

@gaearon gaearon added this to the 0.3.0 milestone Aug 11, 2016
@mxstbr mxstbr mentioned this issue Aug 11, 2016
Merged
mxstbr added a commit that referenced this issue Aug 11, 2016
@mxstbr
Disable dot rule of connect-history-api-fallback
306af69 
Ref #387
gaearon pushed a commit that referenced this issue Aug 11, 2016
@mxstbr @gaearon
Disable dot rule of connect-history-api-fallback (#422)
25a0b66 
Ref #387
gaearon pushed a commit that referenced this issue Aug 25, 2016
@mxstbr @gaearon
Disable dot rule of connect-history-api-fallback (#422)
10bce5a 
Ref #387
@gaearon gaearon modified the milestones: 0.2.3, 0.3.0 Aug 25, 2016
@gaearon
Copy link
Contributor

gaearon commented Aug 25, 2016

Fixed by #422.

@gaearon gaearon closed this as completed Aug 25, 2016
stayradiated pushed a commit to stayradiated/create-react-app that referenced this issue Sep 7, 2016
@mxstbr
Disable dot rule of connect-history-api-fallback (facebook#422)
7e54fa2 
Ref facebook#387
feiqitian pushed a commit to feiqitian/create-react-app that referenced this issue Oct 25, 2016
@mxstbr @feiqitian
Disable dot rule of connect-history-api-fallback (facebook#422)
905157a 
Ref facebook#387
@lock lock bot locked and limited conversation to collaborators Jan 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
issue: proposal tag: underlying tools
Projects
None yet
Milestone
0.2.3
Development

No branches or pull requests
3 participants
@TuckerWhitehouse @gaearon @scottfr