Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Adding Router" recipe #641

Closed
gaearon opened this issue Sep 13, 2016 · 7 comments
Closed

Add "Adding Router" recipe #641

gaearon opened this issue Sep 13, 2016 · 7 comments

Comments

@gaearon
Copy link
Contributor

gaearon commented Sep 13, 2016

Should walk you through installing the new React Router v4 and point to its Quick Start which contains an example ready to be pasted into App.js.

@i1skn
Copy link

i1skn commented Sep 14, 2016

Do somebody already doing this?

@cloudmu
Copy link
Contributor

cloudmu commented Sep 14, 2016

Wondering if this deviates somewhat from spirit of the project. I was also wondering the same about react-bootstrap section (instead of general guidelines to import css) in the user guide.

I like how you reason regarding NOT to include redux (#630).

With that said, I do use redux, react router, bootstrap in my project. They are great for my use cases.

@gaearon
Copy link
Contributor Author

gaearon commented Sep 24, 2016

Redux is an opinionated solution for a problem you might encounter in a month after starting building your app. Routing is something almost all SPAs need, so I think it’s warranted.

Bootstrap section was added because many people did it the wrong way, or thought it’s impossible. We needed to show a happy path there.

@graham-sportsmgmt
Copy link

I'd also like to see at least an add-on for react-router, and agree that this is something all SPA's need.

I'm happy to help, but uncertain how to proceed with helping :)

@bgian
Copy link

bgian commented Feb 13, 2017

I've never messed with React but I've managed to get setup really quickly with this repo (with my little knowledge of front-end).

Would be extremely useful to see how easy it is to get multiple pages setup with this app using react-router for sure 👍

Edit: While this is being worked on, does anyone have recommendations for doing so in the meantime? cc @gaearon

@graham-sportsmgmt
Copy link

I've been poking around the docs for react-router and I feel like I have a pretty good understanding now. I do wish there was a better quick start, but the learning curve isn't monumental.

I'm keeping all my routing logic in index.js, in fact that's all that index.js is used for in my app. The HugeApp sample in react-router gave me some ideas on how to break that up a little, but for now this is working well for me. Hope that helps.

@gaearon
Copy link
Contributor Author

gaearon commented Jan 8, 2018

Fixed by #3709.

@gaearon gaearon closed this as completed Jan 8, 2018
@lock lock bot locked and limited conversation to collaborators Jan 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants