Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add favicon to the generated app #69

Closed
gaearon opened this issue Jul 22, 2016 · 5 comments
Closed

Add favicon to the generated app #69

gaearon opened this issue Jul 22, 2016 · 5 comments

Comments

@gaearon
Copy link
Contributor

gaearon commented Jul 22, 2016

Seems like a nice thing to do + we need to figure out how to do it with webpack 😄
@keyz
Copy link
Contributor

keyz commented Jul 22, 2016 •
edited
Loading

I think html-webpack-plugin supports that. Do we want to put it under template/src?

@keyz keyz mentioned this issue Jul 22, 2016
Merged
@keyz
Copy link
Contributor

keyz commented Jul 22, 2016

#70

@gaearon
Copy link
Contributor Author

gaearon commented Jul 22, 2016

#70 (comment)

@modernserf
Copy link

The app doesn't build if favicon.ico is missing:

> react-scripts start
Starting the development server...
Failed to compile.

Error in   Error: HtmlWebpackPlugin: could not load file /Users/modernserf/work/src/github.com/modernserf/c  ritter/favicon.ico

  - index.js:303
    [critter]/[react-scripts]/[html-webpack-plugin]/index.js:303:27

@gaearon gaearon closed this as completed Jul 22, 2016
@gaearon
Copy link
Contributor Author

gaearon commented Jul 22, 2016

@modernserf Good point. Let’s discuss in #96.

@jchansen jchansen mentioned this issue Feb 10, 2017
Closed
@lock lock bot locked and limited conversation to collaborators Jan 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@gaearon @modernserf @keyz