Add favicon #70
Add favicon #70
Conversation
ghost
added
the
|
👍 |
| @@ -91,6 +91,7 @@ module.exports = { | |||
| new HtmlWebpackPlugin({ | |||
| inject: true, | |||
| template: indexHtmlPath, | |||
| favicon: path.join(srcPath, 'favicon.ico'), | |||
There was a problem hiding this comment.
Does it work if it's in the root folder with HTML instead? This feels more like meta information than app module.
There was a problem hiding this comment.
Do you think it would be better to have a folder that contains static assets (favicon.ico and logo.svg)? I think favicon.ico should be in that folder (let's call it assets?) but not sure about logo.svg.
There was a problem hiding this comment.
And yeah, it works when it's not in the src folder.
There was a problem hiding this comment.
For logo.svg and similar images, since it gets imported from javascript, it's annoying to put it in a different root folder. You would end up with import '../../../../../../../../assets/foo/bar/baz/qux.png' in big projects rather than import './blah.png'. The favicon is different since webpack handles it without js doing anything.
There was a problem hiding this comment.
Yup. I moved favicon.ico to top level since it’s a “magic” file like index.html.
The modules live in src.
Implements #69. The favicon file is taken from https://facebook.github.io/react/.