Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proxy docs still outdated #8661

Closed
ashu8912 opened this issue Mar 16, 2020 · 2 comments
Closed

proxy docs still outdated #8661

ashu8912 opened this issue Mar 16, 2020 · 2 comments

Comments

@ashu8912
Copy link

While going through the docs(specifically this page https://create-react-app.dev/docs/proxying-api-requests-in-development/) i found that proxy docs are still outdated as
const proxy = require('http-proxy-middleware'); is now changed to
const { createProxyMiddleware } = require('http-proxy-middleware');
also another problem that is there is that the codebase on github has these changes already but
i think the docs were not rebuilt after this update

@iamandrewluca
Copy link
Contributor

@ashu8912 that is a breaking change in https://github.com/chimurai/http-proxy-middleware/releases/tag/v1.0.0

Don't think CRA was tested with new major version.

@iamandrewluca
Copy link
Contributor

Fixed in #8515
@ianschmitz

diegodelemos pushed a commit to diegodelemos/reana-ui that referenced this issue Mar 23, 2020
diegodelemos pushed a commit to reanahub/reana-ui that referenced this issue Mar 23, 2020
@lock lock bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants