-
-
Notifications
You must be signed in to change notification settings - Fork 26.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
proxy docs still outdated #8661
Labels
Comments
@ashu8912 that is a breaking change in https://github.com/chimurai/http-proxy-middleware/releases/tag/v1.0.0 Don't think CRA was tested with new major version. |
Fixed in #8515 |
diegodelemos
pushed a commit
to diegodelemos/reana-ui
that referenced
this issue
Mar 23, 2020
* Build error facebook/create-react-app#8680 fixed in facebook/create-react-app#8661 released in [react-scripts `3.4.1`](https://github.com/facebook/create-react-app/releases/tag/v3.4.1).
diegodelemos
pushed a commit
to reanahub/reana-ui
that referenced
this issue
Mar 23, 2020
* Build error facebook/create-react-app#8680 fixed in facebook/create-react-app#8661 released in [react-scripts `3.4.1`](https://github.com/facebook/create-react-app/releases/tag/v3.4.1).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
While going through the docs(specifically this page https://create-react-app.dev/docs/proxying-api-requests-in-development/) i found that proxy docs are still outdated as
const proxy = require('http-proxy-middleware');
is now changed toconst { createProxyMiddleware } = require('http-proxy-middleware');
also another problem that is there is that the codebase on github has these changes already but
i think the docs were not rebuilt after this update
The text was updated successfully, but these errors were encountered: