-
-
Notifications
You must be signed in to change notification settings - Fork 26.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WP5 - Update fork-ts-checker-webpack-plugin [DRAFT] #10004
WP5 - Update fork-ts-checker-webpack-plugin [DRAFT] #10004
Conversation
References: * [hook rename](TypeStrong/fork-ts-checker-webpack-plugin#490) * [include/exclude](TypeStrong/fork-ts-checker-webpack-plugin#450) and [issue options](https://github.com/TypeStrong/fork-ts-checker-webpack-plugin#issues-options) * [release notes 5.0.0](https://github.com/TypeStrong/fork-ts-checker-webpack-plugin/releases/tag/v5.0.0)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall, the only concern is issues
hook tap :)
https://github.com/TypeStrong/fork-ts-checker-webpack-plugin v6.0.1 is now out, might be worth bumping to that |
We should raise that with them if it's doing that. It shouldn't be |
facebook/create-react-app#10004 makes changes to react-dev-utils that are not present in the currently released version pulled down by npm. Revert and reapply once new version of react-dev-utils is released (probably at same time as create-react-app releases Webpack 5 compatible version).
Cherry picked into the wp5 branch - closing this pr |
Update fork-ts-checker-webpack-plugin@5.2.1
References:
Part of making way for Webpack 5 #9994
yarn docker:e2e --test-suite simple
not yet tested but done manual QA locally*cc. @piotr-oles regarding your comment maybe you can help review this one?
Potential breaking changes if anyone externally depends on
react-dev-utils
:react-dev-utils/typescriptFormatter
- it's removed as it's no longer needed in the CRA projectreact-dev-utils/WebpackDevServerUtils
-createCompiler
no longer use argumentsdevSocket
ortscCompileOnError
Removed to keep the code base small and clean