-
-
Notifications
You must be signed in to change notification settings - Fork 26.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Webpack 5 message objects #10121
Conversation
also seem related to #10098 |
When is this fix going to be merged? |
Would love for this fix to get merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on feedback from @raix, we'll merge this in.
I've tested and this still works as expected for Webpack 4.x users.
Co-authored-by: Brody McKee <mrmckeb@gmail.com>
Hello, friends. How long will it take for this merge request to be published? |
Team, please can you let know when this fix is expected to be published? |
This is due in the next release, but I can't say exactly when. It should be in the next few weeks :) |
Could someone create a beta-test tag for the commit b172b5e?_pjax=%23js-repo-pjax-container in the package react-dev-utils (npm, yarn), please? It will be great, we really need it! |
@mrmckeb When are you guys release the minor release? |
This will now be a major release sorry, we're hoping to have an alpha out very soon. |
@mrmckeb Any target dates - ball park ? We used patch-package for now to fix this though. Thank you for your time. |
Just curious—why wasn't this added as a patch release, since it's a bugfix that it seems a bunch of people are relying on? |
@kishoreneelamegam we should be within weeks before v5 alpha (hopefully within two weeks but mind vaccation etc.) @noahgrant we are aware of lagging releases and working on improving this. |
@raix Thank you. No worries For folks looking for a work around: Step 1: Move yarn version to 1, if on yarn 2
Step 2: Add the latest (6.4.7)
|
Are there any plans on releasing it anytime soon? |
Co-authored-by: Brody McKee <mrmckeb@gmail.com>
It's currently released in alpha |
@raix I'm still experiencing this issue when using a CRA build that uses a custom react-scripts and cra-template. These two forks are both largely unmodified, and are based off of the most recent version of CRA. I can see the fix applied in my CRA's packages/react-dev-utils version. When I do In other words this tarball does not have the fix: But the 11.0.4 react-dev-utils here does have it: |
Odd, not sure if npm has a problem in using prereleases react-dev-utils should be at v12 https://www.npmjs.com/package/react-dev-utils Maybe try if yarn got the same issue? |
For those looking for the new dev tools version in npm (as of this post it's next.37), you can find v12 in the versions tab here https://www.npmjs.com/package/react-dev-utils, and then can just update your package json to:
|
Co-authored-by: Brody McKee <mrmckeb@gmail.com>
In webpack 4 message is a string, in webpack 5 it is an object or array.
See conversation here: #7929 (comment)
Closes #9880.