Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove generating .eslintcache #10177

Closed

Conversation

falinsky
Copy link

@falinsky falinsky commented Dec 1, 2020

fixes #10161

No need to generate eslint cache due to performance boost
gained in eslint-webpack-plugin 2.4.1

Pull-request where eslint cache generation was enabled: #9911
Following discussion about performance boost: #9886
Version of eslint-webpack-plugin with recompiling performance improvements: https://github.com/webpack-contrib/eslint-webpack-plugin/releases/tag/v2.4.1

fixes facebook#10161

No need to generate eslint cache due to performance boost
gained in eslint-webpack-plugin 2.4.1
@ianschmitz
Copy link
Contributor

I'm probably missing some context here, but what does disable the cache improve?

@ianschmitz ianschmitz added this to the 4.0.2 milestone Dec 2, 2020
@falinsky
Copy link
Author

falinsky commented Dec 2, 2020

I'm probably missing some context here, but what does disable the cache improve?

The cache was enabled in #9911 in order to improve recompilation time slowness.

It turned out that after enabling it - file .eslintcache started to be generated constantly in the root of the project. That fact annoys different people and provides some issues with errors persisting (see more in #10161).

However, eslint-webpack-plugin got updated to 2.4.1 where issues with slowness were fixed - so now enabling cache is not necessary at all (so it brings only issues without benefits, I guess).

This was referenced Dec 4, 2020
@ianschmitz
Copy link
Contributor

We are moving the file into node_modules in #9977, so #10161 should be taken care of. I'm sure the webpack guys would love to hear if caching is slowing the build down. I'm hesitant to disable without any data to back it up.

@falinsky falinsky closed this Dec 8, 2020
ginpei added a commit to ginpei/shortcuts-demo that referenced this pull request Dec 16, 2020
@edksam
Copy link

edksam commented Dec 23, 2020

This fix doesn't work please. And this is slowing down development for us rookies and it's giving me and my team no joy. A lot of data in terms of frustrations going on web now. I really don't see the need for caching in development and as a noob..

@falinsky falinsky reopened this Dec 23, 2020
@falinsky
Copy link
Author

@ianschmitz reopening this pull-request due to an increasing amount of complaints regarding having eslint caching enabled (#10161)

@petesmc
Copy link

petesmc commented Jan 15, 2021

Cache enabled causes serving old data: #10301

@mcchong
Copy link

mcchong commented Jan 20, 2021

Cache enabled causes serving old data: #10301

Hey hope this makes the next release. I keep running into the above issue where .eslintcache gets stale and the dev server needs to be restarted. It's a bit of a killer.

@iansu iansu modified the milestones: 4.0.2, 4.0.3 Feb 3, 2021
@iansu iansu modified the milestones: 4.0.3, 4.0.4 Feb 22, 2021
@iansu
Copy link
Contributor

iansu commented May 26, 2021

This has been addressed in #10177. The cache directory has been moved into node_modules.

@iansu iansu closed this May 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

.eslintcache constantly generated
7 participants