Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding postcss-cssnext #1047

Closed
wants to merge 1 commit into from
Closed

Adding postcss-cssnext #1047

wants to merge 1 commit into from

Conversation

lukejpreston
Copy link

Postcss-cssnext does the auto prefixing and no one should have to change their project in order to use it. It then means people can start using newer css

@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

If you are contributing on behalf of someone else (eg your employer): the individual CLA is not sufficient - use https://developers.facebook.com/opensource/cla?type=company instead. Contact cla@fb.com if you have any questions.

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@lukejpreston
Copy link
Author

Looking through the past issues:

  • I don't feel it is the same as Optional Sass Support #78 as it is not an optional plugin and does not add complexity.
  • Also I don't think you are locking yourself into postcss as in this issue Add postcss-use plugin #213. It is letting people write newer css with no configuration or changes

Pretty trivial low impact change allowing people to write next-gen css

@fson
Copy link
Contributor

fson commented Nov 20, 2016

Adding postcss-cssnext was discussed in #130. The problem is that many of the plugins in cssnext are not stable enough (see #130 (comment)) to be included in Create React App. We can only ship transforms that are really stable and rock solid. At the time there was no consensus on what could be such a subset of transforms.

Adding support for experimental CSS features is not without complexity – some plugins implement features only partially, some implement an older version of the spec or have bugs. There is a risk of having conflicts when the actual spec is implemented in the browsers.

@fson fson closed this Nov 20, 2016
@lock lock bot locked and limited conversation to collaborators Jan 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants